Add support for secrets for helm v2

[laghoule]

It's possible to use helm v2 with added security mesure (disable tiller svc & secrets instead of configmaps):

helm init --history-max 5 --service-account tiller --override 'spec.template.spec.containers[0].command'='{/tiller,--listen=127.0.0.1:44134,--storage=secret}

In order to support this feature, I have add a flag --helm-store to the detect-helm command. I have tested it with my EKS sandbox cluster (1.15.x) with installed helm 2.14.2.

[laghoule]

I forgot to update the readme.md. If you're interresed with this PR, I will update it.

[lucasreed]

Hey @laghoule, thanks so much for this PR! I've commented inline for some change requests as well as a couple questions I had.

[lucasreed]

I forgot to update the readme.md. If you're interresed with this PR, I will update it.

An update to the README would be great! Fine to add that at the end when the other review items are updated. Thanks!

[sudermanjr]

Love the addition, thanks!

I think Luke covered most of the things in here, I just added a couple little things that I noticed.

[sudermanjr]

The venom tests aren't running right now due to Quay outage. I don't think your changes will break them, but you might consider adding some to cover the new functionality

[laghoule]

I have already made a test coverage of the new functionality ;)

[codecov]

Codecov Report

Merging #79 into master will increase coverage by 0.25%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   78.23%   78.49%   +0.25%     
==========================================
  Files           6        6              
  Lines         363      372       +9     
==========================================
+ Hits          284      292       +8     
- Misses         52       53       +1     
  Partials       27       27              

Impacted Files	Coverage Δ
pkg/helm/helm.go	65.95% <83.33%> (+2.42%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e3a06...c526c8e. Read the comment docs.

[sudermanjr]

I have already made a test coverage of the new functionality ;)

Sorry, I wasn't clear. We have two sets of tests, functional and unit. You got the unit tests covered (which is awesome, thank you).

We also have functional testing with Venom in the e2e directory. Those are the ones I was referring to.

[sudermanjr]

LGTM. Thanks for the quick changes!

[lucasreed]

I did add one more minor nitpick change, if you wouldn't mind accepting my suggested modification.

Otherwise this looks great, thank you so much!! 🎉

[pwhitehead00]

Any chance this could be cut in a new release? thanks!!

[lucasreed]

Any chance this could be cut in a new release? thanks!!

Yep! We have something else we want to get in before the new release, but it should be soon.

[sudermanjr]

Just released v2.3.0 which contains that change. Thanks again!

[pwhitehead00]

thank you!!!