Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle multiple values files #974

Merged
merged 1 commit into from
Jul 24, 2023
Merged

feat: handle multiple values files #974

merged 1 commit into from
Jul 24, 2023

Conversation

mikutas
Copy link
Contributor

@mikutas mikutas commented Jul 15, 2023 •
edited

This PR fixes #970

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

What changes did you make?

What alternative solution should we consider, if any?

@mikutas mikutas marked this pull request as ready for review July 15, 2023 10:10
rbren
rbren approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

My understanding is this will be automatically backward-compatible--lmk if that's a bad assumption.

@rbren rbren merged commit 9be3423 into FairwindsOps:master Jul 24, 2023
4 checks passed
@mikutas mikutas deleted the 970-multiple-values branch July 24, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbren rbren rbren approved these changes

@mggude mggude Awaiting requested review from mggude

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

looks like polaris doesn't support multiple values yaml file
2 participants
@mikutas @rbren