Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Optargs #37

Closed
thw26 opened this issue Jan 5, 2024 · 1 comment · Fixed by #40
Closed

Separate Optargs #37

thw26 opened this issue Jan 5, 2024 · 1 comment · Fixed by #40
Assignees
Labels
bug Something isn't working cli Related to the CLI, optargs, or TUI interface regression Related to something that was working but is not
Milestone

Comments

@thw26
Copy link
Collaborator

thw26 commented Jan 5, 2024

Per #34, we need to separate optargs as being either runtime variable setters or actions/commands.

The Bash script did this by iterating over the optargs twice, once for setters, once for actions.

How should we best handle this?

Should the GUI app be made into one panel rather than two, by making "install" an option on the control panel?

@thw26 thw26 added bug Something isn't working alpha regression Related to something that was working but is not cli Related to the CLI, optargs, or TUI interface labels Jan 5, 2024
@thw26 thw26 added this to the Beta milestone Jan 5, 2024
@n8marti
Copy link
Collaborator

n8marti commented Jan 5, 2024

For the GUI there still needs to be 2 windows, but it could be made to start with the "Control Panel" window and there include an "Install" button that would open the "Install" window. I think that should be a separate PR from separating the optarg logic, though, because they're separate problems to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Related to the CLI, optargs, or TUI interface regression Related to something that was working but is not
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants