Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host the generated FakeItEasy.Analyzers docs on the FakeItEasy website #54

Closed
blairconrad opened this issue Nov 22, 2022 · 4 comments · Fixed by #55
Closed

Host the generated FakeItEasy.Analyzers docs on the FakeItEasy website #54

blairconrad opened this issue Nov 22, 2022 · 4 comments · Fixed by #55

Comments

@blairconrad
Copy link
Member

No description provided.

@blairconrad blairconrad mentioned this issue Nov 22, 2022
9 tasks
@blairconrad blairconrad changed the title add the generated FakeItEasy.Analzyers docs to this repo add the generated FakeItEasy.Analzyers docs to the FakeItEasy website Nov 22, 2022
@blairconrad blairconrad changed the title add the generated FakeItEasy.Analzyers docs to the FakeItEasy website Host the generated FakeItEasy.Analzyers docs on the FakeItEasy website Nov 22, 2022
@blairconrad
Copy link
Member Author

Current URL

https://fakeiteasy.readthedocs.io/projects/analyzers/en/stable/

Proposal:
https://fakeiteasy.github.io/docs/analyzers/en/stable/

@thomaslevesque, any objection to this URL? I'm open to alternatives for the "analyzers" segment (or most of the rest).

Also, we'll eventually have to decide where to put the main FIE docs. With the above URL, just hosting the main docs at

https://fakeiteasy.github.io/docs/en/stable/

might cause conflicts? TBH I'm not sure. I guess only if we have an article called "en" (or pick your favourite language code).

If we want to entertain that URL, I guess we could be thinking of

Or something else I can't think of right now. Have you any preferences?

@thomaslevesque
Copy link
Member

Your proposal sounds good to me, except for the /en part. We don't have docs in multiple languages, so why include the language in the URL?

With the above URL, just hosting the main docs at

https://fakeiteasy.github.io/docs/en/stable/

might cause conflicts?

I wondered about that, but I think it should be fine. We'll need to try to be sure.

If it causes issues, I'd go with https://fakeiteasy.github.io/docs/fakeiteasy/stable and https://fakeiteasy.github.io/docs/analyzers/stable

@blairconrad
Copy link
Member Author

I can drop en. Had thought to include because

  • readthedocs does
  • if we ever want to add multiple languages, it'd be easier

all that being said, it's very unlikely we'll ever translate. Happy to drop.

Will try out

Thanks!

@blairconrad
Copy link
Member Author

blairconrad commented Nov 23, 2022

Steps for adding the docs:

  1. check out FakeItEasy.Analyzers (I used master, since its docs have the 6.1.0 content and the material for mkdocs styling)
  2. ensure the proper python packages are installed (feel free to use a virtual environment):
    pip install -r docs/requirements.txt
  3. check out fakeiteasy.github.io
  4. create host-analyzers-docs branch from upstream/master. Do not switch to it. Stay on master
  5. add the docs
    mike deploy 6.1 stable --branch host-analyzers-docs --prefix docs/analyzers --update-aliases -- 
    config-file ..\FakeItEasy.Analyzers\mkdocs.yml

this will add docs for 6.1 with the alias "stable" pointing at them, and commit on the host-analyzer-docs branch

As a bonus:

mike set-default stable -b host-analyzers-docs --prefix docs/analyzers --config-file ..\FakeItEasy.Analyzers\mkdocs.yml

to make "stable" the default branch, so we can visit https://fakeiteasy.github.io/docs/analyzers/

We shouldn't need to "set-default" in the future.

@thomaslevesque thomaslevesque changed the title Host the generated FakeItEasy.Analzyers docs on the FakeItEasy website Host the generated FakeItEasy.Analyzers docs on the FakeItEasy website Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants