Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonarr V4 support #207

Open
1 task done
quorn23 opened this issue Aug 27, 2022 · 9 comments
Open
1 task done

Sonarr V4 support #207

quorn23 opened this issue Aug 27, 2022 · 9 comments

Comments

@quorn23
Copy link

quorn23 commented Aug 27, 2022

Description

Currentlyy Jellyseerr isn't working with Sonarr V4.
This is an early request as V4 is in development.

sonarr:v4 tag available
https://github.com/hotio/sonarr/pkgs/container/sonarr

Desired Behavior

Being able to add a Sonarr V4 instance to Jellyseerr as well.

Additional Context

No response

Code of Conduct

  • I agree to follow Overseerr's Code of Conduct
@hosaka
Copy link

hosaka commented Nov 18, 2022

Sonarr v4 has no Language Profiles. The rest of the API should be the same. Perhaps having a Sonarr Version dropdown and not trying to get language profiles when v4 is selected would suffice? I can help with some initial support for this.

@Fallenbagel
Copy link
Owner

Fallenbagel commented Dec 3, 2022

Sonarr v4 is now supported on jellyseerr/overseerr. Specifically Sonarr V4.0.0.205

@hosaka
Copy link

hosaka commented Dec 6, 2022

Thank you, working with jellyseerr 1.2.1 and sonarr v4.0.0.240

@quorn23
Copy link
Author

quorn23 commented Dec 6, 2022

@Fallenbagel just be aware, the compatibility is due of back porting the endpoints. This is only a temporary fix, as Overseerr (and to that extend) Jellyseerr aren't supporting V4 (yet). It's still deprecated and still needs a proper fix.

@Fallenbagel
Copy link
Owner

@Fallenbagel just be aware, the compatibility is due of back porting the endpoints. This is only a temporary fix, as Overseerr (and to that extend) Jellyseerr aren't supporting V4 (yet). It's still deprecated and still needs a proper fix.

The only thing is the language profile that's breaking the connection. So nothing to be too much scared about going on from here

@angrycuban13
Copy link
Contributor

You should look at properly supporting V4 and not relying on a fix from Qstick to get some third party applications working. Besides, continuing to use deprecated endpoints creates unnecessary warnings on Sonarr event logs that something is using a deprecated endpoint.

@bakerboy448
Copy link

bakerboy448 commented Dec 6, 2022

Hitting an endpoint that is depreciated - and thus likely to be removed eventually - and not fixing it doesn't really make logical sense nor does it fix the issue.

All closing this does is kicks the can down the road where eventually the same issue will occur and Sonarr won't be supported.
image

@hosaka an API version endpoint has been added; or status also has the version as well. either one would allow V4 to be determined and to skip trying to use language profiles in v4 given this is not fixed and is closed in error.

@Fallenbagel Fallenbagel reopened this Dec 6, 2022
@hosaka
Copy link

hosaka commented Dec 7, 2022

@bakerboy448 Yeah I gathered that this is not "support for v4" from seeing "deprecated" language profile and no relevant commits on the develop branch, but it does make sonarr usable for the time being. I'm a bit confused about where the development is happening. Is the plan for jellyseerr to eventually merge this from upstream overseerr or PRs will be accepted in this repo?

@Fallenbagel
Copy link
Owner

@bakerboy448 Yeah I gathered that this is not "support for v4" from seeing "deprecated" language profile and no relevant commits on the develop branch, but it does make sonarr usable for the time being. I'm a bit confused about where the development is happening. Is the plan for jellyseerr to eventually merge this from upstream overseerr or PRs will be accepted in this repo?

For overseerr specific feature like sonarr v4, we would like the PR to go upstream so we can merge from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants