Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot open most text files from titles beyond Mario & Luigi Dream Team (Kuriimu1) #23

Open
LolHacksRule opened this issue Sep 3, 2020 · 5 comments
Labels
bug Something isn't working Text An issue describing help to support an text format in Kuriimu2.

Comments

@LolHacksRule
Copy link

Describe the bug
Most text files (MSBT) extracted from Mario and Luigi RPGs beyond 4 (Dream Team) and the remasters fail to be read by Kuriimu.

To Reproduce
Steps to reproduce the behavior:

  1. Extract game data from ROM
  2. Navigate to 'Msg/XX_xx'
  3. Drag text file on Kuriimu
  4. Error is shown and the file doesn't load

Expected behavior
File opens properly without problems aside from control code issues.

Screenshots
If applicable, add screenshots to help explain your problem.

The problematic text files all output this message:

image

And some output this message when the file is extracted completely fine from the ROM and read by the game correctly.

image

Desktop (please complete the following information):

  • OS: Windows (10, x64)
  • Browser: Google Chrome
  • Version: 9041

Smartphone (please complete the following information):

  • Device: Android
  • OS: 8.0.1
  • Browser: Chrome
  • Version: ???

Additional context
Other tools for MSBT work with a portion (Reloaded)/all of them (Toolbox/msyt) but have the same control code issues with the formatting. The staff at Karameru's Discord recommended me to start an issue here instead of Kuriimu's repo. Any plans to fix it before porting the text plugin?

Problematic text files (Superstar Saga, US English)

Problematic text files (Paper Jam [Retail Demo/Kiosk], EU English)

@IcySon55
Copy link
Member

IcySon55 commented Sep 3, 2020

The Superstar Saga files look fairly normal so there might be a bug introduced recently. For now, try an older version of Kuriimu 1.

@LolHacksRule
Copy link
Author

Ok thanks

@kenshiisod
Copy link

kenshiisod commented Apr 13, 2021

I think both msyt (msbt-rs) and Kuriimu assume that the padding character (0xAB) will exist before the section but for these particular MSBTs null padding is used.

@kenshiisod
Copy link

kenshiisod commented Apr 13, 2021

I fixed this for msbt-rs by not relying on 0xAB and instead skipping to the nearest 0x16. anna-is-cute/msbt-rs#4

@onepiecefreak3 onepiecefreak3 added bug Something isn't working Text An issue describing help to support an text format in Kuriimu2. labels Apr 28, 2021
@MarioForever91
Copy link

What exactly is the version of Kuriimu1 that works with the superstar saga msbt files?
I have tested all versions from 1.0.9 to the latest and none have worked.
Would it be possible for someone to point me to one that works?
NOTE: Sorry for my English. I don't speak English well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Text An issue describing help to support an text format in Kuriimu2.
Projects
None yet
Development

No branches or pull requests

5 participants