Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quill 2 Support #45

Open
saulfrr opened this issue Mar 8, 2024 · 5 comments
Open

Quill 2 Support #45

saulfrr opened this issue Mar 8, 2024 · 5 comments

Comments

@saulfrr
Copy link

saulfrr commented Mar 8, 2024

Hi, now that Quill Version 2.0.0-rc.2 is there, do you have plans to support it?

npm ERR! Could not resolve dependency:
npm ERR! peer quill@"^1.3.4" from quill-blot-formatter@1.0.5
npm ERR! node_modules/quill-blot-formatter
npm ERR! quill-blot-formatter@"*" from the root project

Thanks.

@LukasKlement
Copy link

This fork works fine with Quill Version 2: https://github.com/juandjara/quill-blot-formatter-mobile

To avoid type errors, make sure to register it with as any:
Quill.register('modules/blotFormatter', BlotFormatter as any);

@adgoncal
Copy link

@saulfrr you can add an override to package.json:

  "overrides": {
    "quill-blot-formatter": {
      "quill": "^2.0.0"
    }
  },

@xwiz
Copy link

xwiz commented May 23, 2024

Thanks, can you open a PR with support for 2.0

@saulfrr you can add an override to package.json:

  "overrides": {
    "quill-blot-formatter": {
      "quill": "^2.0.0"
    }
  },

@enzedonline
Copy link

Overriding the quill version doesn't make it compatible unfortunately. Quill 2 has a very different methodology for applying styles.

The resizing still works fine, but the alignments (found in actions/align/DefaultAligner.js) need updating to the new syntax. Currently, these do not get written to the delta.

@enzedonline
Copy link

enzedonline commented Jun 28, 2024

I have a working version here. It's converted to TypeScript and uses custom Quill formats to apply the alignments.

2024-06-28-162544-ezgif com-optimize

Feel free to clone etc if it's useful to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants