Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting for non-Window class. #14

Closed
wakuflair opened this issue Nov 10, 2016 · 7 comments
Closed

Supporting for non-Window class. #14

wakuflair opened this issue Nov 10, 2016 · 7 comments

Comments

@wakuflair
Copy link

It seems that mvvm-dialogs only supports standard Window or inherited class.
We use telerik wpf controls, in which there's a window-like control named "RadWindow", it's not inherited from Window class, mvvm-dialogs can't handle it.
IMO, mvvm-dialogs should abstract the "window", you just need it to show(RadWindow also has Show/ShowDialog methods).

@FantasticFiasco
Copy link
Owner

I'll take a look at it.

Is it possible for you to provide a simple sample without breaking any licensing issues with Telerik?

@wakuflair
Copy link
Author

I just created a new repo to show you the code:
https://github.com/wakuflair/MvvmDialogWithTelerik

@FantasticFiasco
Copy link
Owner

Thanks, I'll have a look at it!

@FantasticFiasco
Copy link
Owner

I've uploaded a NuGet pre-release called MvvmDialogs 3.0.12-beta.

In order to support custom windows, you'll have to implement a new interface called MvvmDialogs.IWindow. Can you verify that your code is working as expected when targeting this pre-release?

If you have any problems with the implementation of IWindow, please take a look at the demo application.

@wakuflair
Copy link
Author

Awesome! The new version worked very well!
I also updated the MvvmDialogWithTelerik demo source code.
Thank you again!

@FantasticFiasco
Copy link
Owner

I'll prepare the code for an official release, I'll notify you when I've uploaded the NuGet package.

@FantasticFiasco
Copy link
Owner

There is now an official release of MVVM Dialogs on NuGet with version 4.0.0.

Thank you for your feedback, and if you encounter any problems please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants