Async support on IMessageTypeResolver

[gsferreira]

Review interface and implementation to use Async/Await.

From

    public interface IMessageTypeResolver
    {
        Type OnConsume(IMessageContext context);

        void OnProduce(IMessageContext context);
    }

To

    public interface IMessageTypeResolver
    {
        Task<Type> OnConsumeAsync(IMessageContext context);

        Task OnProduceAsync(IMessageContext context);
    }

[mhkolk]

How did this change already make in into master (release)? I'm having issues with this.

The overload

.AddSerializer(
                    resolver => new JsonMessageSerializer(...),
                    resolver => new YourTypeResolver(...))

no longer works.

I downloaded the source, referenced it in my app and debug.

Seems to me the execution never progresses from this this piece of code

        public static IConsumerMiddlewareConfigurationBuilder AddSerializer<TSerializer, TResolver>(
            this IConsumerMiddlewareConfigurationBuilder middlewares,
            Factory<TSerializer> serializerFactory,
            Factory<TResolver> resolverFactory)
            where TSerializer : class, ISerializer
            where TResolver : class, IMessageTypeResolver
        {
            return middlewares.Add(
                resolver => new SerializerConsumerMiddleware(
                    serializerFactory(resolver),
                    resolverFactory(resolver)));
        }

The new SerializerConsumerMiddleware() constructor never gets called.

UPDATE: Had to revert to 2.2.13 to get custom type resolver working.

[massada]

@mhkolk the constructor not being called indicates that the issue is with the middleware not being called. We have no indication of custom resolvers not working with the changes. Both kinds are used throughout the code, integration tests are passing and we have no issues in production.

Can you please provide a repo or snippet with the issue so that we can try to reproduce?

[mhkolk]

This is really weird. I couldnt get the custom type resolver to work with 2.2.15 last week. Spent a day debugging that's why I reverted to 2.2.13. Today I updated again to 2.2.15 and it works.