Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain is not pure kotlin code #12

Open
rakib-bk opened this issue Apr 6, 2022 · 1 comment
Open

Domain is not pure kotlin code #12

rakib-bk opened this issue Apr 6, 2022 · 1 comment

Comments

@rakib-bk
Copy link

rakib-bk commented Apr 6, 2022

The domain class is using gson annotation. In clean architecture we write pure java/kotlin code in domain layer. The gson annotated class will remain in data layer and a mapper should be used to convert it from data layer to domain layer. Please correct me if I am wrong.

@HiImMatthewN
Copy link

You are correct, even the repository contains the 'PagingData' which is from the Android Paging Library itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants