Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Life Stages to the Guide Creation Process #333

Merged
merged 21 commits into from Dec 8, 2014

Conversation

simonv3
Copy link
Member

@simonv3 simonv3 commented Dec 4, 2014

An update that adds life stages to the guide creation process. Relevant to #311, waiting on #237 to move forward.

What's changed

  • Now you can choose stages to add to your guide
    screenshot 2014-12-04 11 49 27
  • And you can choose what shows up in those stages:
    screenshot 2014-12-04 11 50 20

What's next

  • Enabling image uploads for the stages (the frontend part of this is done, just need to know how to actually send them to the backend (Add images to stages for each guide. #237, @RickCarlino)
  • Visual styling of the last page to be in line with the guide creation flow (recruit @warpling).
  • Start thinking about how Stage Actions will work.
  • Probably remove the requirements model for each guide.
  • Add a couple more things to the F.A.Q. Probably think of how the FAQ can be edited on here and read automatically into the site (a faq.md in assets that gets loaded with javascript and converted to the right thing?)
  • Guides will need to be visually updated (recruit @warpling again).
  • Guide editing will need to remove the instructions field.

I will break those above out to their own issues.

if (attrs.s3Stage){
scope.filename = attrs.s3Default;
} else {
scope.filename = ngModel.$viewValue;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace.

}) || null,
}
console.log(stageParams);
$http.post('/api/stages/', stageParams)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'stageParams' is not defined.

sent++;
console.log('completed sending', sent);
if (sent === $scope.newGuide.selectedStages.length){
window.location.href = "/guides/" + guide._id + "/edit/";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

sent++;
console.log('completed sending', sent);
if (sent === $scope.newGuide.selectedStages.length){
window.location.href = "/guides/" + guide._id + "/edit/";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

@simonv3
Copy link
Member Author

simonv3 commented Dec 4, 2014

I have installed a whitespace linter on my sublime. I'm sorry all.

field :days_end, type: Integer
field :instructions, type: String
field :length, type: Integer # Length in days
field :where, type: Array
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really want to have a field on a model called where? Isn't that going to cause a naming collision for database queries with a where clause defined by Mongoid?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we do not!

array :soil
array :light
integer :stage_length
array :images, class: String, arrayize: true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put one space between the method name and the first argument.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 00d3923 on simonv3:life-stages into cca6eeb on FarmBot:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 00d3923 on simonv3:life-stages into cca6eeb on FarmBot:master.

simonv3 added a commit that referenced this pull request Dec 8, 2014
Add Life Stages to the Guide Creation Process
@simonv3 simonv3 merged commit 79d1f5c into openfarmcc:master Dec 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants