New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Life Stages to the Guide Creation Process #333
Conversation
Missing link to back end, properly adding images, length of time, and annual repetition
if (attrs.s3Stage){ | ||
scope.filename = attrs.s3Default; | ||
} else { | ||
scope.filename = ngModel.$viewValue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing whitespace.
}) || null, | ||
} | ||
console.log(stageParams); | ||
$http.post('/api/stages/', stageParams) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'stageParams' is not defined.
sent++; | ||
console.log('completed sending', sent); | ||
if (sent === $scope.newGuide.selectedStages.length){ | ||
window.location.href = "/guides/" + guide._id + "/edit/"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
sent++; | ||
console.log('completed sending', sent); | ||
if (sent === $scope.newGuide.selectedStages.length){ | ||
window.location.href = "/guides/" + guide._id + "/edit/"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
I have installed a whitespace linter on my sublime. I'm sorry all. |
field :days_end, type: Integer | ||
field :instructions, type: String | ||
field :length, type: Integer # Length in days | ||
field :where, type: Array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really want to have a field on a model called where
? Isn't that going to cause a naming collision for database queries with a where
clause defined by Mongoid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we do not!
array :soil | ||
array :light | ||
integer :stage_length | ||
array :images, class: String, arrayize: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put one space between the method name and the first argument.
Add Life Stages to the Guide Creation Process
An update that adds life stages to the guide creation process. Relevant to #311, waiting on #237 to move forward.
What's changed
What's next
I will break those above out to their own issues.