Upgrading some gems. #342
Upgrading some gems. #342
Conversation
|
Hey @vraravam, thanks so much for the PR! It looks like bumping the version for active_models_serializers breaks the API. Any thoughts what the difference would be? |
…s the app - will investigate later tomorrow.
|
I have reverted that gem alone to the previous version and locked it in the Gemfile. Please verify/consider for merge. |
… can work out of the box (also changed hound config to point to this file). Fixed lots of rubocop warnings.
| garden_crop = Garden.find(params[:garden_id]). | ||
| garden_crops.find(params[:id]) | ||
| garden_crop = Garden.find(params[:garden_id]) | ||
| .garden_crops.find(params[:id]) |
There was a problem hiding this comment.
Place the . on the previous line, together with the method call receiver.
|
Hey @vraravam, Thanks again! A good idea is to run the tests ( It's also better if you don't conform files that you haven't worked on for the PR to a style guide (like for Hound), usually it ends up creating problems (like in this case). The idea is that slowly those will conform to the style guide as code gets refactored, it's usually less messy to do it that way. |
|
Hi @vraravam, thanks for the PR, we always appreciate the help. Unfortunately, I don't feel comfortable merging this PR and am going to close it. Many of your changes help us conform to a style guide, which is definitely a good thing, but I do not think it is appropriate for us to change working production code for the sake of complying to a style guide. This is especially true if the changes are being made by someone who did not write the original code and may not have a complete understanding of any underlying complexity. In the past this has always (not sometimes) resulted in higher occurrences of errors on the production site. In the future, please update the style of code only when implementing new features or bug fixes. Sorry for any confusion. |
|
hi Rick, On Mon, Dec 8, 2014 at 8:58 AM, Rick Carlino notifications@github.com
|
No description provided.