Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Merge Statements in Trip.py Init #92

Closed
danielsclint opened this issue Oct 13, 2017 · 1 comment
Closed

Invalid Merge Statements in Trip.py Init #92

danielsclint opened this issue Oct 13, 2017 · 1 comment

Comments

@danielsclint
Copy link

These merge statements don't always work, because the id column of trips_df was changed earlier in this method. The merge columns need to be explicitly set.

https://github.com/BayAreaMetro/fast-trips/blob/e3ceaf3926a9ca05a2acf2cae6382cf273bdfb8b/fasttrips/Trip.py#L315
@danielsclint
Copy link
Author

This turned out to be a non-issue. I was confused about member variable and method variable declarations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielsclint