Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary ResponseParam doesn't work with JsonPropertyName #511

Closed
rage4 opened this issue Oct 24, 2023 · 1 comment
Closed

Summary ResponseParam doesn't work with JsonPropertyName #511

rage4 opened this issue Oct 24, 2023 · 1 comment
Labels
bug Something isn't working fixed the bug has been squashed

Comments

@rage4
Copy link

rage4 commented Oct 24, 2023

Hi. First of all, thanks for the awesome framework. At Rage4, we are moving most of our codebase to the FE.
We are not sure if it is a bug or not, but we have noticed the following behaviour:

  1. Create a response record (SampleResponse) with, let's say, an IsActive property (boolean)
  2. Add the JsonPropertyName attribute to be serialized to 'is_active'.
  3. Add the Summary with s.ResponseParam(o => o.IsActive, "Entity status");

I would expect that the Swagger would have the correct description. Unfortunately, it's empty.
Is there any workaround? Something similar to s.Params, so it would accept the dictionary?

Thanks. Piotr

@KateyBee
Copy link
Member

KateyBee commented Oct 25, 2023

Thanks for reporting this.
It has been fixed in v5.18.0.8-beta.
Hoping to do a final release around the 3rd of November.

@dj-nitehawk dj-nitehawk added bug Something isn't working fixed the bug has been squashed labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed the bug has been squashed
Development

No branches or pull requests

3 participants