Factory.Create no longer runs Configure on the Endpoint

[Jmaharman]

Firstly thank you for this excellent library, we started using it about a year ago and love it's simplicity and power.

We're currently updating from 5.2.1 to the latest and we noticed that Configure is no longer called on the Endpoint when using Factory.Create.

I've looked at the source code and it seems to have been introduced from the following commit:

dependency resolving support for endpoint Configure() method - 77d656e

the crux of it is that ImplementsConfigure and EndpointAttributes are no longer set. I was going to PR my change which gets it workin, seen below on lines 32 and 33, but I imagine that's now how you want to implement it.

Test added:

public class FactoryCreateTests
{
    [Fact]
    public async Task ConfigureIsExecuted()
    {
        var ep = Factory.Create<ConfigureEndpoint>();

        ep.Definition.Routes.Should().ContainSingle("configure/test");
    }
}

public class ConfigureEndpoint : Endpoint<Request, Response>
{

    public override void Configure()
    {
        Verbs(Http.GET);
        Routes("configure/test");
    }

    public override Task HandleAsync(Request r, CancellationToken ct)
    {
        return SendErrorsAsync();
    }
}

[dj-nitehawk]

wow not sure how that went unnoticed 🤦‍♂️
fixed in 5.21.1.1-beta and thank you so much for hunting down the cause.
much appreciated!

[Jmaharman]

wow, thanks so much for the quick turn around. We're testing it now.

[dj-nitehawk]

you're most welcome. it was fast because you found the exact cause :-)
a patch release v5.21.2 has been pushed to nuget.
should be live in a few minutes.

[Jmaharman]

It worked perfectly by the way, thanks again!