Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe a bug in update_kv function #3

Open
HarryWu99 opened this issue Apr 27, 2024 · 1 comment
Open

maybe a bug in update_kv function #3

HarryWu99 opened this issue Apr 27, 2024 · 1 comment

Comments

@HarryWu99
Copy link

attention_mask = mask[None, None, :, :]

In update_kv function, instead of using the function's arguments attention_mask, this variable is overridden.

@leeyeehoo
Copy link
Collaborator

leeyeehoo commented Apr 28, 2024

Just refactored the codebase. I think the arg is dummy and will remove it in the future update. You can test to see if there is any bug! Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants