Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience methods to for constructing IonObjectMapper.Builder #249

Merged
merged 1 commit into from Feb 19, 2021

Conversation

mcliedtke
Copy link
Contributor

This was referenced in #246 and it appears that it may have been resolved by accident.

In any case, this serves to just add some convenience to the creation of an IonObjectMapper:

  • Explicitly creating a builder for text or binary writers
  • Allow a specified IonSystem at builder construction time
  • Add convenience methods for setting IonGenerator.Feature or IonParser.Feature

These convenience methods respect the current defaults:

I've made this change to the 2.12 branch but this isn't urgent and can be moved to 2.13, though it should be backwards compatible

@cowtowncoder
Copy link
Member

Agreed, this is a good improvement. Just one question: should this go against 2.13? Ideally since it's API addition, it should; although 2.12.2 is bit special with quite a few non-compliant additions (to resolve existing problems).

@mcliedtke
Copy link
Contributor Author

I am not particularly strongly opinionated one way or the other. I pretty much had the same thought that 2.12.2 is already a bit special and this doesn't seem all that different to include. But it is also purely just added convenience so there is no rush and could easily wait until 2.13

@cowtowncoder
Copy link
Member

@mcliedtke Ok. With that, I think I might as well just merge it as-is :)

@cowtowncoder cowtowncoder modified the milestones: 2, 2.12.2 Feb 19, 2021
@cowtowncoder cowtowncoder merged commit eb0b61b into FasterXML:2.12 Feb 19, 2021
@cowtowncoder
Copy link
Member

Ah. Was about to comment on inability to set IonParser/Generator features... until I realized they will work, just need to do it bit different. So that's fine. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants