Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Navigation Icons #32

Open
timbuckingham opened this issue Sep 27, 2018 · 1 comment
Open

Basic Navigation Icons #32

timbuckingham opened this issue Sep 27, 2018 · 1 comment

Comments

@timbuckingham
Copy link
Collaborator

https://github.com/Fastspot/Boilerplate/blob/master/src/twig/partials/navigation/basic.twig

How often is it that we use basic navigation with different icons on a per link basis? From the CMS perspective I think it would be much easier to pass in the same icon for all the links in a set as a single parameter rather than injecting it into the link in the array.

@nhall
Copy link
Collaborator

nhall commented Mar 19, 2019

Now we are using a single nav partial and I think we want to keep it as an icon per link. There are a lot of times we have things like secondary or utility navs where each item gets an icon:

image

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants