Milestone 3: To Do list (Interactive list) #4
Conversation
Favourezeugwa
commented
Jun 3, 2022
Favourezeugwa
commented
- Implemented a function for the "Clear all completed" button.
- Implemented a function for the checkbox.
- Added event listener to the checkbox.
There was a problem hiding this comment.
Hi @Favourezeugwa ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✅ linter error checks validated
✅ Documented your work professionally
✅ README file is descriptive.
✅ Commit messages are meaningful.
Required Changes ♻️
- Please your App is not working. Kindly remember the description of the Project: In this project, you will add some functionality to your application to make it interactive. The user will also be able to mark task completion by selecting the corresponding checkbox (or undo it by unchecking the checkbox). The updated tasks list will be stored in local storage
- Here is the Link: Project description
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
Hi Oliphiche, My app works, you just have to click on the Add to your list, then click the enter key. I'd kindly like to hear your feedback, Thank you! |
There was a problem hiding this comment.
Hi @Favourezeugwa and @OLIPLICHE,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
