Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread Factory for serialEventThread #308

Closed
rusefillc opened this issue Jul 25, 2020 · 3 comments
Closed

Thread Factory for serialEventThread #308

rusefillc opened this issue Jul 25, 2020 · 3 comments

Comments

@rusefillc
Copy link
Contributor

At the moment serialEventThread is created explicitly inside the library and there is no way to inject thread name and/or thread daemon flag. In order to make the library more flexible please consider allowing ThreadFactory injection into SerialPort.getCommPort.

I am happy to provide a PR if that would help.

Thank you for a great library!

@hedgecrw
Copy link
Contributor

Hi there, yes please submit a PR for this functionality!

@rusefillc
Copy link
Contributor Author

@hedgecrw please elaborate on the "closed" status

is that "we are not interested in having this request open unless there is a PR"
or is that "done"
or is that "won't fix"

@hedgecrw
Copy link
Contributor

Closed as "won't fix unless a PR is created". Happy to include this functionality, but as it is relatively low-impact in terms of critical functionality, we ask that it be introduced via PR. Thanks!

rusefillc added a commit to rusefi/jSerialComm that referenced this issue May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants