Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When trying to edit or create a Constraint when the FeatureModel is void there is an error occurring with the Constraint Dialog. #823

Closed
oliviia12 opened this issue Sep 28, 2018 · 5 comments

Comments

@oliviia12
Copy link

screenshot from 2018-09-28 16-20-11

@tthuem
Copy link
Member

tthuem commented Oct 1, 2018

Thanks for the report.

@jsprey
Copy link
Contributor

jsprey commented Oct 17, 2018

An identical but different error also appears when saving a void feature model.
The actuator is also "Creating Empty clause?". Occurs while the configurations are checked and if the model is void.

@jsprey
Copy link
Contributor

jsprey commented Oct 17, 2018

Here are the full stack traces for both errors:

Error orccuring when opening constraint dialog:

org.sat4j.specs.ContradictionException: Creating Empty clause ?
	at org.sat4j.minisat.constraints.cnf.Clauses.propagationCheck(Clauses.java:117)
	at org.sat4j.minisat.constraints.cnf.Clauses.sanityCheck(Clauses.java:97)
	at org.sat4j.minisat.constraints.MixedDataStructureDanielWL.createClause(MixedDataStructureDanielWL.java:81)
	at org.sat4j.minisat.core.Solver.addClause(Solver.java:401)
	at org.prop4j.solver.BasicSolver.addClause(BasicSolver.java:134)
	at org.prop4j.solver.BasicSolver.addCNF(BasicSolver.java:122)
	at org.prop4j.solver.BasicSolver.addVariables(BasicSolver.java:94)
	at org.prop4j.solver.BasicSolver.<init>(BasicSolver.java:71)
	at de.ovgu.featureide.fm.ui.editors.ConstraintTextValidator$InitialAnalysis.execute(ConstraintTextValidator.java:142)
	at de.ovgu.featureide.fm.ui.editors.ConstraintTextValidator$InitialAnalysis.execute(ConstraintTextValidator.java:1)
	at de.ovgu.featureide.fm.core.job.Executer.execute(Executer.java:44)
	at de.ovgu.featureide.fm.core.job.LongRunningJob.work(LongRunningJob.java:48)
	at de.ovgu.featureide.fm.core.job.AbstractJob.run(AbstractJob.java:121)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)

Error occuring when saving a void feature model:

org.sat4j.specs.ContradictionException: Creating Empty clause ?
	at org.sat4j.minisat.constraints.cnf.Clauses.propagationCheck(Clauses.java:117)
	at org.sat4j.minisat.constraints.cnf.Clauses.sanityCheck(Clauses.java:97)
	at org.sat4j.minisat.constraints.MixedDataStructureDanielWL.createClause(MixedDataStructureDanielWL.java:81)
	at org.sat4j.minisat.core.Solver.addClause(Solver.java:401)
	at org.prop4j.solver.BasicSolver.addClause(BasicSolver.java:134)
	at org.prop4j.solver.BasicSolver.addCNF(BasicSolver.java:122)
	at org.prop4j.solver.BasicSolver.addVariables(BasicSolver.java:94)
	at org.prop4j.solver.BasicSolver.<init>(BasicSolver.java:71)
	at de.ovgu.featureide.core.internal.FeatureProject$7.execute(FeatureProject.java:1089)
	at de.ovgu.featureide.core.internal.FeatureProject$7.execute(FeatureProject.java:1)
	at de.ovgu.featureide.fm.core.job.Executer.execute(Executer.java:44)
	at de.ovgu.featureide.fm.core.job.LongRunningJob.work(LongRunningJob.java:48)
	at de.ovgu.featureide.fm.core.job.AbstractJob.run(AbstractJob.java:121)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)

@jsprey
Copy link
Contributor

jsprey commented Oct 17, 2018

@skrieter

I created a small examples regarding this problem.
home and professtional

The CNF is as followed:
(Test) & (Test | -Base) & (Base | -Test) & (-Base)

When adding the last clause -Base to the solver it throws a contradiction exception.

Now I catch the ContradictionException and imply that the feature model is void.

Now the error does not longer appear and the constraint editor works as intended.
home and professtional

@jsprey
Copy link
Contributor

jsprey commented Oct 17, 2018

Sames goes for the error appearing when checking configurations while the feature model is void.

@jsprey jsprey closed this as completed in d31dc0c Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants