Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering of menus doesn't look right #178

Closed
nparkanyi opened this issue Sep 15, 2022 · 2 comments
Closed

Rendering of menus doesn't look right #178

nparkanyi opened this issue Sep 15, 2022 · 2 comments

Comments

@nparkanyi
Copy link
Contributor

  • The little blue highlight bar is missing on the selected menu
  • Poor contrast on the submenu arrow
  • The selection rectangle seems to spill outside the boundary a bit
    adwaitaqt_menu
@nparkanyi
Copy link
Contributor Author

With this:

--- a/src/style/adwaitastyle.cpp
+++ b/src/style/adwaitastyle.cpp
@@ -4932,7 +4932,7 @@ bool Style::drawMenuBarItemControl(const QStyleOption *option, QPainter *painter
     if (useStrongFocus && sunken) {
         StyleOptions styleOptions(painter, QRect(rect.left(), rect.bottom() - 2, rect.width(), 3));
         styleOptions.setColorVariant(_variant);
-        styleOptions.setOutlineColor(Colors::focusColor(StyleOptions(palette, _variant)));
+               styleOptions.setColor(Colors::focusColor(StyleOptions(palette, _variant)));
         Adwaita::Renderer::renderFocusRect(styleOptions);
     }

the highlight rectangle shows up (though it's not the right shade of blue).
adwaitaqt_menu2

@nparkanyi nparkanyi mentioned this issue Sep 18, 2022
@grulja
Copy link
Collaborator

grulja commented Dec 7, 2022

Fixed with #179.

@grulja grulja closed this as completed Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants