Add the WifiPage #159

HosamHasanRamadan · 2021-10-30T20:15:28Z

related to #20 .
this pull request is a good starting point for the wifi page.
the current features that the page has :

toggle wifi on-off
connect to access points listed in the UI
the page is totally reactive to the wifi adaptor state
shows error page when wifi adaptor isn't accessible

Still a lot missing from the page but it is just the start.

Feichtmeier · 2021-10-31T07:56:35Z

Thank you very much @HosamHasanRamadan !!!

I test it today

Feichtmeier · 2021-10-31T14:22:29Z

@HosamHasanRamadan

Checked out locally:

Correctly displays connections and wifi strength
But I can not connect to an access point, error is:

[ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: org.freedesktop.NetworkManager.UnknownConnection: The device 'wlp0s20f3' has no connections available for activation.
#0      DBusClient._callMethod
<asynchronous suspension>
#1      DBusClient.callMethod
<asynchronous suspension>
#2      NetworkManagerClient.activateConnection
<asynchronous suspension>
#3      WifiModel.connectToAccesPoint
<asynchronous suspension>

Feichtmeier · 2021-10-31T14:23:03Z

@Jupi007 could you add more wifi icons for the connection strength in yaru_icons when you have time? :)

HosamHasanRamadan · 2021-10-31T15:36:40Z

ok, I think I know where is the problem.
you can reject this pull request I will make a new one fixing this issue and I will add new features too.
thank you for your feedback.

Feichtmeier · 2021-10-31T16:09:11Z

You could also just work on this one if you like :)

HosamHasanRamadan · 2021-11-01T20:50:07Z

I hope it works for you now

Jupi007 · 2021-11-02T08:15:58Z

@Jupi007 could you add more wifi icons for the connection strength in yaru_icons when you have time? :)

With pleasure @Feichtmeier :)

Jupi007 · 2021-11-02T08:58:45Z

@Feichtmeier We already have that kind of icons:

@HosamHasanRamadan Can you replace MdiIcons with YaruIcons please? Here are corresponding names:

MdiIcons.wifiStrength(Lock)Outline -> YaruIcons.network_wireless_signal_none(_secure)
MdiIcons.wifiStrength1(Lock) -> YaruIcons.network_wireless_signal_weak(_secure)
MdiIcons.wifiStrength2(Lock) -> YaruIcons.network_wireless_signal_ok(_secure)
MdiIcons.wifiStrength3(Lock) -> YaruIcons.network_wireless_signal_good(_secure)
MdiIcons.wifiStrength4(Lock) -> YaruIcons.network_wireless_signal_excellent(_secure)
MdiIcons.wifiOff -> YaruIcons.network_wireless_disabled

HosamHasanRamadan · 2021-11-02T09:58:19Z

done

Jupi007 · 2021-11-02T09:59:08Z

Thanks @HosamHasanRamadan :)

lib/view/pages/wifi/widgets/authentication_dialog.dart

HosamHasanRamadan · 2021-11-02T11:09:08Z

Done

Feichtmeier · 2021-11-03T08:17:48Z

Thanks @HosamHasanRamadan
Tested again and more stuff works!

The list of access points is populated with duplicates though, any idea why this happens?

HosamHasanRamadan · 2021-11-03T08:26:34Z

Does it duplicate the access point that you recently connected to through the app or it duplicates all the access points ?

Feichtmeier · 2021-11-04T09:08:02Z

No discovered access points in general. Also it only refreshes when you open up gnome control center parallel to this.

Feichtmeier · 2021-11-06T08:47:25Z

@HosamHasanRamadan

Take a look at
https://github.com/canonical/ubuntu-desktop-installer/blob/9df535ba41eaa0b77e4dc3ce971710ebc8b7faf9/packages/ubuntu_desktop_installer/lib/pages/connect_to_internet/wifi_model.dart#L166
jpnurmi uses the ListEquality funtion from the collections package, maybe this could help

HosamHasanRamadan · 2021-11-06T09:09:32Z

@HosamHasanRamadan

Take a look at

https://github.com/canonical/ubuntu-desktop-installer/blob/9df535ba41eaa0b77e4dc3ce971710ebc8b7faf9/packages/ubuntu_desktop_installer/lib/pages/connect_to_internet/wifi_model.dart#L166

jpnurmi uses the ListEquality funtion from the collections package, maybe this could help

Do you still have the problem of duplicate access points ?

Feichtmeier · 2021-11-06T09:21:04Z

Yes, pulled every commit but still duplications

HosamHasanRamadan · 2021-11-06T09:26:48Z

Ok I will fix today . Later I want to discuss with you that the comparison mechanism using only ssid isn't enough because you may have two access points with same ssid .

HosamHasanRamadan · 2021-11-06T15:48:04Z

Duplicate access points issue is fixed, please check it out @Feichtmeier

Feichtmeier · 2021-11-06T18:21:06Z

@HosamHasanRamadan thanks for working so much on this!

Just pulled and rebuild sadly not fixed for me

Maybe I am doing something wrong. @Jupi007 could you check if you have the same issue?

HosamHasanRamadan · 2021-11-06T20:13:30Z

I can't run the app on my ubuntu virtual machine because of this error , if you know how to solve this error so I could test the app on it

[ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: Invalid argument(s): Failed to load dynamic library 'libgio-2.0.so': libgio-2.0.so: cannot open shared object file: No such file or directory
#0      _open (dart:ffi-patch/ffi_dynamic_library_patch.dart:11)
#1      new DynamicLibrary.open (dart:ffi-patch/ffi_dynamic_library_patch.dart:20)
#2      gio (package:gsettings/src/gio.dart:9)
#3      new GSettings._new (package:gsettings/src/settings.dart:266)
#4      new GSettings (package:gsettings/src/settings.dart:252)
#5      main (package:settings/main.dart:18)
#6      main (file:///home/hosam/Desktop/ubuntu/settings/.dart_tool/flutter_build/generated_main.dart)
#7      _runMainZoned.<anonymous closure>.<anonymous closure> (dart:ui/hooks.dart:143)
#8      _rootRun (dart:async/zone.dart:1428)
#9      _CustomZone.run (dart:async/zone.dart:1328)
#10     _runZoned (dart:async/zone.dart:1863)
#11     runZonedGuarded (dart:async/zone.dart:1851)
#12     _runMainZoned.<anonymous closure> (dart:ui/hooks.dart:141)
#13     _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:283)
#14     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184)

r

Jupi007 · 2021-11-06T22:44:35Z

Maybe I am doing something wrong. @Jupi007 could you check if you have the same issue?

I'm really sorry @Feichtmeier but I can't test this at all because I don't use Wifi on my desktop, and I don't have any other computer 😔

HosamHasanRamadan · 2021-11-07T09:09:06Z

I am running the release binary of on the app bundle , I think it doesn't need flutter as a runtime dependency.

Feichtmeier · 2021-11-07T09:09:40Z

I can't run the app on my ubuntu virtual machine because of this error , if you know how to solve this error so I could test the app on it

[ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: Invalid argument(s): Failed to load dynamic library 'libgio-2.0.so': libgio-2.0.so: cannot open shared object file: No such file or directory
#0      _open (dart:ffi-patch/ffi_dynamic_library_patch.dart:11)
#1      new DynamicLibrary.open (dart:ffi-patch/ffi_dynamic_library_patch.dart:20)
#2      gio (package:gsettings/src/gio.dart:9)
#3      new GSettings._new (package:gsettings/src/settings.dart:266)
#4      new GSettings (package:gsettings/src/settings.dart:252)
#5      main (package:settings/main.dart:18)
#6      main (file:///home/hosam/Desktop/ubuntu/settings/.dart_tool/flutter_build/generated_main.dart)
#7      _runMainZoned.<anonymous closure>.<anonymous closure> (dart:ui/hooks.dart:143)
#8      _rootRun (dart:async/zone.dart:1428)
#9      _CustomZone.run (dart:async/zone.dart:1328)
#10     _runZoned (dart:async/zone.dart:1863)
#11     runZonedGuarded (dart:async/zone.dart:1851)
#12     _runMainZoned.<anonymous closure> (dart:ui/hooks.dart:141)
#13     _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:283)
#14     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184)

r

Try either refreshing the flutter snap from edge or removing it and installing it manually from git and add the path to your bashrc

Feichtmeier · 2021-11-07T09:13:50Z

sudo snap remove flutter

git clone https://github.com/flutter/flutter.git -b master

edit $HOME/.bashrc

Add at the end

export PATH="$PATH:[PATH_OF_FLUTTER_GIT_DIRECTORY]/bin"

Replace the path including the [ ] with the real path to where you've cloned flutter to

Feichtmeier · 2021-11-07T09:56:25Z

I am running the release binary of on the app bundle , I think it doesn't need flutter as a runtime dependency.

I don't have your issue running flutter inside vscode or in the bundle.

May I ask why you don't use vscode, vscode flutter extension and a normal flutter installation? :)

HosamHasanRamadan · 2021-11-07T10:42:28Z

I am running the release binary of on the app bundle , I think it doesn't need flutter as a runtime dependency.

I don't have your issue running flutter inside vscode or in the bundle.

May I ask why you don't use vscode, vscode flutter extension and a normal flutter installation? :)

It's my last solution because I run Ubuntu on a virtual machine with limited resources.
I will install flutter on the virtual machine and give it a try before changing the code

HosamHasanRamadan · 2021-11-07T10:43:26Z

Note to self:
I compare between access points using ssid and hwAddress which makes sense to me but the Ubuntu installer pull request uses only ssid for comparison but in a situation when you have two access points with the same ssid only one will be shown .
On the other hand , my solution leads to duplicate access points and I don't know right now where is the source of problem.
If the problem is with the nm library don't forget to report the issue.

HosamHasanRamadan · 2021-11-07T12:45:32Z

I tested the app on my ubuntu virtual machine and I don't have the issue of the duplicate access points

Feichtmeier · 2021-11-07T15:33:17Z

Move a bit in your room for changes then ☺️

HosamHasanRamadan · 2021-11-07T15:39:32Z

Move a bit in your room for changes then ☺️

I use Wi-Fi dongle in my pc 😅.
I will change my code to compare between access using ssid only

HosamHasanRamadan · 2021-11-09T12:49:02Z

I am almost sure now that you won't have duplicate access points this time 😅🤞

Feichtmeier · 2021-11-09T14:16:22Z

Yes, now it works! 🥂
Is it ready to merge from your side?

HosamHasanRamadan · 2021-11-10T12:01:53Z

Yes, now it works! 🥂

Is it ready to merge from your side?

Yes 🙌👍

Feichtmeier · 2021-11-10T16:02:01Z

Edit: no, we remove the test for now, sec

Hosam Hasan added 5 commits October 30, 2021 21:55

add material design icons to use wifi icons

78fea72

initiallize network client before injecting it

7f964a9

add leading widget for showing wifi icons

e2b6481

view models for wifi page

d912959

UI of the wifi page

1274367

Hosam Hasan added 5 commits November 1, 2021 22:28

add extension helper methods for nm library classes

dd15979

add 'authentication' data class

2e7e8b4

add auth feature form unknown access points connections

34b6563

add auth feature for unknown access points connections

6346027

Merge branch 'master' of https://github.com/HosamHasanRamadan/settings

aec14f5

Hosam Hasan added 2 commits November 2, 2021 11:56

use yaru icons instead of mdi icons

c009bc6

remove unused mdi package

f77b5b9

Feichtmeier reviewed Nov 2, 2021

View reviewed changes

lib/view/pages/wifi/widgets/authentication_dialog.dart Show resolved Hide resolved

Feichtmeier reviewed Nov 2, 2021

View reviewed changes

lib/view/pages/wifi/widgets/authentication_dialog.dart Outdated Show resolved Hide resolved

Hosam Hasan added 2 commits November 2, 2021 13:03

add 'const' where ever it possible

795d5b4

remove prints

a7d0cb0

Hosam Hasan added 2 commits November 6, 2021 17:43

refactoring

90227ed

fix the issue of duplicate access points

a280cc7

Hosam Hasan added 2 commits November 9, 2021 14:34

refactor access point ssid and name

f32137d

use ssid as the only ID for access points and connections

6b39a20

Feichtmeier added 3 commits November 10, 2021 16:40

Revert '' to "" change

5d46ac2

Fix typos

84091db

Setingsrow: simplify null check for leadingWidget

d9a0d09

Feichtmeier changed the title ~~The starting code base of the Wifi page~~ Add the WifiPage Nov 12, 2021

Feichtmeier merged commit 76003b1 into ubuntu-flutter-community:master Nov 12, 2021

Add the WifiPage #159

Add the WifiPage #159

Conversation

HosamHasanRamadan commented Oct 30, 2021

Feichtmeier commented Oct 31, 2021

Feichtmeier commented Oct 31, 2021

Feichtmeier commented Oct 31, 2021

HosamHasanRamadan commented Oct 31, 2021

Feichtmeier commented Oct 31, 2021

HosamHasanRamadan commented Nov 1, 2021

Jupi007 commented Nov 2, 2021

Jupi007 commented Nov 2, 2021

HosamHasanRamadan commented Nov 2, 2021

Jupi007 commented Nov 2, 2021

HosamHasanRamadan commented Nov 2, 2021

Feichtmeier commented Nov 3, 2021

HosamHasanRamadan commented Nov 3, 2021

Feichtmeier commented Nov 4, 2021

Feichtmeier commented Nov 6, 2021

HosamHasanRamadan commented Nov 6, 2021

Feichtmeier commented Nov 6, 2021

HosamHasanRamadan commented Nov 6, 2021

HosamHasanRamadan commented Nov 6, 2021

Feichtmeier commented Nov 6, 2021

HosamHasanRamadan commented Nov 6, 2021

Jupi007 commented Nov 6, 2021

HosamHasanRamadan commented Nov 7, 2021

Feichtmeier commented Nov 7, 2021

Feichtmeier commented Nov 7, 2021 • edited

Feichtmeier commented Nov 7, 2021

HosamHasanRamadan commented Nov 7, 2021

HosamHasanRamadan commented Nov 7, 2021

HosamHasanRamadan commented Nov 7, 2021 • edited

Feichtmeier commented Nov 7, 2021

HosamHasanRamadan commented Nov 7, 2021

HosamHasanRamadan commented Nov 9, 2021

Feichtmeier commented Nov 9, 2021

HosamHasanRamadan commented Nov 10, 2021

Feichtmeier commented Nov 10, 2021 • edited

Feichtmeier commented Nov 7, 2021 •

edited

HosamHasanRamadan commented Nov 7, 2021 •

edited

Feichtmeier commented Nov 10, 2021 •

edited