Info page #32

Jupi007 · 2021-08-03T17:29:46Z

Work in progress branch for the info page.

Get OS infos
Get CPU infos
Get graphic infos (using https://github.com/LolzDEV/linux_system_info) ;
Disk infos (using https://github.com/canonical/udisks.dart) ;
Get 32/64 bit info ;
Get gnome-shell infos ;
Get wayland/X.org info ;
Get hostname ;
Make hostname editable.

Closes #24

jpnurmi · 2021-09-12T20:56:36Z

Get graphic infos (can't found a library sadly) ;

https://github.com/LolzDEV/linux_system_info/pull/3 😉

Jupi007 · 2021-09-13T08:28:57Z

Get graphic infos (can't found a library sadly) ;

LolzDEV/linux_system_info#3 wink

Awesome!
Big thanks to you 😃

jpnurmi · 2021-09-14T16:10:39Z

Get 32/64 bit info ;

One option would be to use dart:ffi to extract the size of a pointer:

import 'dart:ffi';

bool get is32Bit => sizeOf<IntPtr>() == 4;
bool get is64Bit => sizeOf<IntPtr>() == 8;

Given that Flutter doesn't officially support 32-bit Linux, however, it's quite unlikely that anyone will ever run the Settings app on a 32-bit system. Technically, it's possible to build Flutter for 32-bit Linux (e.g. flutter-pi) if you're willing to go deep enough, though. 😄

jpnurmi · 2021-09-14T16:33:55Z

Get computer name.

The dbus package has an example that is a good starting point:

import 'package:dbus/dbus.dart';

var client = DBusClient.system();
var object = DBusRemoteObject(client, destination: 'org.freedesktop.hostname1', path: DBusObjectPath('/org/freedesktop/hostname1'));
var hostname = await object.getProperty('org.freedesktop.hostname1', 'Hostname');
print('hostname: ${hostname.toNative()}');
await client.close();

What gnome-control-center does:

get hostname:
- get the 'PrettyHostname' property and if not set, use the 'Hostname' property as a fallback
set hostname:
- call 'SetPrettyHostname' with the user input as it is
- call 'SetStaticHostName' with a safe sanitized value:
  - the algorithm (pretty_hostname_to_static) is here: https://gitlab.gnome.org/GNOME/gnome-control-center/-/blob/master/panels/common/hostname-helper.c#L103

jpnurmi · 2021-09-14T16:37:46Z

Get wayland/X.org info ;

import 'dart:io';

bool get isX11 => sessionType == 'x11';
bool get isWayland => sessionType == 'wayland';
String? get sessionType => Platform.environment['XDG_SESSION_TYPE'];

jpnurmi · 2021-09-14T18:07:18Z

Get gnome-shell infos ;

https://github.com/LolzDEV/linux_system_info/pull/4

- Gpu name - Hostname - OS type - Gnome version - Window server

Jupi007 · 2021-09-17T18:56:43Z

Here is the current state of the info page:

@jpnurmi I integrated as I could all your advice (surly like a big noob 😓). Big thanks for your help :)

jpnurmi · 2021-09-17T20:04:31Z

Hi @Jupi007, have you looked at the series of view model PRs from @mivoligo? It would be great to use the pattern here too so we could move the D-Bus stuff etc. out of the widget tree. :)

Disk infos with unix_disk_space

Let's try to figure out something nicer. That package looks pretty inactive and it's creating a child process to run the df command. 👀 I think we could try to use udisks.dart instead. 🙂

Make hostname editable.

I was playing with this. I can push a service class to help with setting the pretty hostname and sanitizing the static hostname.

jpnurmi · 2021-09-17T21:05:13Z

import 'package:filesize/filesize.dart';
import 'package:udisks/udisks.dart';

Future<void> main() async {
  final client = UDisksClient();
  await client.connect();
  final total = client.drives.fold<int>(0, (sum, drive) => sum + drive.size);
  print(filesize(total)); // 954 GB
  await client.close();
}

jpnurmi · 2021-09-18T19:54:58Z

Very nice! 👍 Are the only remaining things GPU info and disk capacity?

Jupi007 · 2021-09-18T20:16:34Z

Very nice! +1 Are the only remaining things GPU info and disk capacity?

Yes 😃
I also plan to add a popup window for editing the hostname.

Feichtmeier · 2021-09-18T21:08:56Z

Very nice! +1 Are the only remaining things GPU info and disk capacity?

Yes 😃
I also plan to add a popup window for editing the hostname.

Good idea, then we could fix this issue #59 (a half of the issue) within this PR. I think another page for only the hostname is pretty pointless

Jupi007 · 2021-09-18T22:24:46Z

Tada ✨

Jupi007 · 2021-09-19T17:53:31Z

P.S. I think GCC got the terminology and spelling right. Any reason to deviate? ("64-bit" vs. "64 Bits", "GNOME" vs. "Gnome", "Windowing System" vs. "Window server")

About the terminology, I based my work on the french version where it is written "64 Bits" 😅

Are those the only wrong terms?

Jupi007 · 2021-09-19T18:23:57Z

Looks very nice!

I get this error - am I doing something wrong?

[ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: Bad state: Cannot add event after closing
#0      _StreamController.add (dart:async/stream_controller.dart:553:24)
#1      HostnameService._updateHostname
#2      HostnameService._initProperties
<asynchronous suspension>
#3      HostnameService.init
<asynchronous suspension>
#4      InfoModel.init
<asynchronous suspension>

I got it too. It looks related to the HostnameService. @jpnurmi What do you think of?

jpnurmi · 2021-09-19T18:49:10Z

@Feichtmeier There's something wrong with the master-detail navigation. Whenever you navigate to a page, it's creating 3 instances of that page, and immediately disposes one of them (before the model & service had a chance to even finish initialization).

jpnurmi · 2021-09-19T19:01:47Z

@Feichtmeier Did you ever try https://github.com/jpnurmi/flutter_master_detail_example? I don't know if it's perfect either, but it's not trying to do anything "smart" tricks with custom overlay routes at least.

jpnurmi · 2021-09-19T19:04:32Z

P.S. We could easily guard HostnameService against this, but it wouldn't fix the problem because then the model will be next in line and explode in its initialization routines... And any other view+model with asynchronous initialization will face the same issue. :(

jpnurmi · 2021-09-19T19:38:26Z

Here's an example how we can guard against "too early" disposal:

diff --git a/lib/view/pages/info/hostname_service.dart b/lib/view/pages/info/hostname_service.dart
index 4ccb402..1295499 100644
--- a/lib/view/pages/info/hostname_service.dart
+++ b/lib/view/pages/info/hostname_service.dart
@@ -62,8 +62,12 @@ class HostnameService {
     _prettyHostname = prettyHostname ?? _prettyHostname;
     _staticHostname = staticHostname ?? _staticHostname;
 
-    _hostnameController.add(this.hostname);
-    _staticHostnameController.add(this.staticHostname);
+    if (!_hostnameController.isClosed) {
+      _hostnameController.add(this.hostname);
+    }
+    if (!_staticHostnameController.isClosed) {
+      _staticHostnameController.add(this.staticHostname);
+    }
   }
 
   Future<void> _initProperties() async {
diff --git a/lib/view/pages/info/info_model.dart b/lib/view/pages/info/info_model.dart
index 1707e01..0f6e90b 100644
--- a/lib/view/pages/info/info_model.dart
+++ b/lib/view/pages/info/info_model.dart
@@ -20,6 +20,7 @@ class InfoModel extends ChangeNotifier {
 
   String _gpuName = '';
   int? _diskCapacity;
+  bool _wasDisposed = false;
 
   Future<void> init() async {
     await _hostnameService.init();
@@ -32,7 +33,9 @@ class InfoModel extends ChangeNotifier {
       _diskCapacity = _uDisksClient.drives.fold<int>(0, (sum, drive) => sum + drive.size);
     });
 
-    notifyListeners();
+    if (!_wasDisposed) {
+      notifyListeners();
+    }
   }
 
   String get hostname => _hostnameService.hostname;
@@ -57,6 +60,7 @@ class InfoModel extends ChangeNotifier {
 
   @override
   void dispose() {
+    _wasDisposed = true;
     _hostnameService.dispose();
     _uDisksClient.close();
     super.dispose();

jpnurmi · 2021-09-19T20:10:49Z

Add safe_change_notifier as a dependency, and change ChangeNotifier to SafeChangeNotifier. :)

jpnurmi · 2021-09-19T20:11:41Z

It seems to be a surprisingly common problem, so I made quickly a package out of it. :P I'll write docs and tests later.

jpnurmi · 2021-09-19T20:13:38Z

@Jupi007 Are you not using automatic formatting for Dart code? I get a bit of diff here when touching files.

Jupi007 · 2021-09-19T20:55:56Z

Add safe_change_notifier as a dependency, and change ChangeNotifier to SafeChangeNotifier. :)

Done :)

@Jupi007 Are you not using automatic formatting for Dart code? I get a bit of diff here when touching files.

I don't think I have automatic formatting enabled. Does this require a specific ext?

mivoligo · 2021-09-19T21:13:32Z

I don't think I have automatic formatting enabled. Does this require a specific ext?

If you use VSCode, look in Settings for "sdk formatter" and make sure it's enabled

Jupi007 · 2021-09-19T21:44:58Z

Just checked, and it is enabled. ~~Should I do anything special to run the formatter?~~
I enabled formatOnSave and now it works.

Feichtmeier · 2021-09-19T21:48:07Z

Just checked, and it is enabled. Should I do anything special to run the formatter?

CTRL + SHIFT + I formats the document just in case the auto format does not work

jpnurmi

LGTM 👍

jpnurmi · 2021-09-20T07:22:13Z

pubspec.yaml

@@ -6,7 +6,7 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
 version: 1.0.0+1

 environment:
-  sdk: ">=2.12.0 <3.0.0"
+  sdk: ">=2.14.0 <3.0.0"


linux_system_info has >=2.12.0 <3.0.0: https://github.com/LolzDEV/linux_system_info/blob/master/pubspec.yaml#L7

as said, project-wide language version constraint changes shouldn't be part of an unrelated PR

Feichtmeier · 2021-09-20T08:09:23Z

Shall we merge?

Jupi007 · 2021-09-20T08:10:04Z

Ok for me.

@jpnurmi ?

jpnurmi · 2021-09-20T08:10:33Z

Go for it! 👍

Jupi007 · 2021-09-20T08:17:20Z

Thanks a lot for your help on this @jpnurmi :)
I couldn't have done it without you.

Wip info page

1f75362

Jupi007 marked this pull request as draft August 3, 2021 17:29

Update linux_system_info to 0.0.6

19530dc

Merge branch 'master' into info_page

bff4077

Jupi007 added 4 commits September 17, 2021 20:38

Add useful packages

ab637a6

Clean single_info_row code

a8fafeb

Add many missing infos

77d730c

- Gpu name - Hostname - OS type - Gnome version - Window server

Merge branch 'master' into info_page

4eb0729

Jupi007 requested a review from jpnurmi September 17, 2021 18:57

Jupi007 marked this pull request as ready for review September 17, 2021 20:29

Jupi007 added 2 commits September 18, 2021 10:37

Merge branch 'master' into info_page

0c202a5

Move to model

e61ecd4

Jupi007 added 4 commits September 18, 2021 23:21

Get gpu name

89073ab

Get disk capacity

3a77715

Move hostname to new top section

6680724

Make hostname editable

ca1ba85

Drop unused file

7521794

Jupi007 added 3 commits September 19, 2021 20:10

Move info class call to constructor

7f61905

Use int for numbers

3c72ec3

Fix terminology

da0f8b1

Feichtmeier mentioned this pull request Sep 19, 2021

There's something wrong with the master-detail navigation #78

Closed

Merge branch 'master' into info_page

208350c

jpnurmi mentioned this pull request Sep 19, 2021

Guard HostnameService against early disposal #79

Merged

Use SafeChangeNotifier

38ffbbd

Format files

029e3d5

jpnurmi reviewed Sep 20, 2021

View reviewed changes

Revert sdk version

b4b9d6a

jpnurmi changed the title ~~Wip info page~~ Info page Sep 20, 2021

Jupi007 merged commit dc10a11 into master Sep 20, 2021

Jupi007 deleted the info_page branch September 20, 2021 08:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Info page #32

Info page #32

Jupi007 commented Aug 3, 2021 •

edited

jpnurmi commented Sep 12, 2021

Jupi007 commented Sep 13, 2021

jpnurmi commented Sep 14, 2021

jpnurmi commented Sep 14, 2021

jpnurmi commented Sep 14, 2021

jpnurmi commented Sep 14, 2021

Jupi007 commented Sep 17, 2021 •

edited

jpnurmi commented Sep 17, 2021

jpnurmi commented Sep 17, 2021 •

edited

jpnurmi commented Sep 18, 2021

Jupi007 commented Sep 18, 2021

Feichtmeier commented Sep 18, 2021 •

edited

Jupi007 commented Sep 18, 2021

Jupi007 commented Sep 19, 2021 •

edited

Jupi007 commented Sep 19, 2021

jpnurmi commented Sep 19, 2021

jpnurmi commented Sep 19, 2021

jpnurmi commented Sep 19, 2021

jpnurmi commented Sep 19, 2021

jpnurmi commented Sep 19, 2021

jpnurmi commented Sep 19, 2021

jpnurmi commented Sep 19, 2021

Jupi007 commented Sep 19, 2021

mivoligo commented Sep 19, 2021

Jupi007 commented Sep 19, 2021 •

edited

Feichtmeier commented Sep 19, 2021

jpnurmi left a comment

jpnurmi Sep 20, 2021

Feichtmeier commented Sep 20, 2021

Jupi007 commented Sep 20, 2021

jpnurmi commented Sep 20, 2021

Jupi007 commented Sep 20, 2021

Info page #32

Info page #32

Conversation

Jupi007 commented Aug 3, 2021 • edited

jpnurmi commented Sep 12, 2021

Jupi007 commented Sep 13, 2021

jpnurmi commented Sep 14, 2021

jpnurmi commented Sep 14, 2021

jpnurmi commented Sep 14, 2021

jpnurmi commented Sep 14, 2021

Jupi007 commented Sep 17, 2021 • edited

jpnurmi commented Sep 17, 2021

jpnurmi commented Sep 17, 2021 • edited

jpnurmi commented Sep 18, 2021

Jupi007 commented Sep 18, 2021

Feichtmeier commented Sep 18, 2021 • edited

Jupi007 commented Sep 18, 2021

Jupi007 commented Sep 19, 2021 • edited

Jupi007 commented Sep 19, 2021

jpnurmi commented Sep 19, 2021

jpnurmi commented Sep 19, 2021

jpnurmi commented Sep 19, 2021

jpnurmi commented Sep 19, 2021

jpnurmi commented Sep 19, 2021

jpnurmi commented Sep 19, 2021

jpnurmi commented Sep 19, 2021

Jupi007 commented Sep 19, 2021

mivoligo commented Sep 19, 2021

Jupi007 commented Sep 19, 2021 • edited

Feichtmeier commented Sep 19, 2021

jpnurmi left a comment

Choose a reason for hiding this comment

jpnurmi Sep 20, 2021

Choose a reason for hiding this comment

Feichtmeier commented Sep 20, 2021

Jupi007 commented Sep 20, 2021

jpnurmi commented Sep 20, 2021

Jupi007 commented Sep 20, 2021

Jupi007 commented Aug 3, 2021 •

edited

Jupi007 commented Sep 17, 2021 •

edited

jpnurmi commented Sep 17, 2021 •

edited

Feichtmeier commented Sep 18, 2021 •

edited

Jupi007 commented Sep 19, 2021 •

edited

Jupi007 commented Sep 19, 2021 •

edited