Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallpaper page: add dark mode support #406

Closed
Jupi007 opened this issue Nov 26, 2022 · 13 comments
Closed

Wallpaper page: add dark mode support #406

Jupi007 opened this issue Nov 26, 2022 · 13 comments
Labels
feature / enhancement Needs implementation

Comments

@Jupi007
Copy link
Collaborator

Jupi007 commented Nov 26, 2022

In the current state, the wallpaper is defined for both dark/light theme.
GS supports to have different wallpaper depending on the theme, and it would be nice to add this feature here.

CC @YoussefLasheen if you want to grab it :)

@Jupi007 Jupi007 added the feature / enhancement Needs implementation label Nov 26, 2022
@shan-shaji
Copy link
Member

@Jupi007 can i take a look at this? I would like to get a little more details and what should be the behaviour that i should achieve.

@Jupi007
Copy link
Collaborator Author

Jupi007 commented Feb 4, 2023

@shan-shaji ofc you can 🙂

@shan-shaji
Copy link
Member

ok thank you @Jupi007

@shan-shaji
Copy link
Member

@Jupi007 can i please get a bit more context about the feature?

@Feichtmeier
Copy link
Member

basically when you set the wallpaper from the chosen file you need to check what the current theme is and change the gsettings key corresponding to this

@shan-shaji
Copy link
Member

@Feichtmeier , i am not that much familiar with gsettings. Really sorry.. do we have any docs?

@Feichtmeier
Copy link
Member

Sadly not many docs but you can check what WallpaperModel does and at some point it sets the wallpaper, I think I remember you only need to make a case for the dark wallpaper there

@Jupi007
Copy link
Collaborator Author

Jupi007 commented Feb 4, 2023

Currently, the wallpaper is set twice: once for light theme once for the dark one.

@shan-shaji
Copy link
Member

Got it

@shan-shaji
Copy link
Member

shan-shaji commented Feb 4, 2023

@Jupi007v @Feichtmeier but i think the current behaviour supports different wallpaper depending on the theme.

@shan-shaji
Copy link
Member

ezgif com-gif-maker (1)

@Feichtmeier
Copy link
Member

Nice 👍🙂

@Jupi007
Copy link
Collaborator Author

Jupi007 commented Feb 4, 2023

Closing, as this feature has been added in #321

@Jupi007 Jupi007 closed this as completed Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature / enhancement Needs implementation
Projects
None yet
Development

No branches or pull requests

3 participants