New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallpaper page: add dark mode support #406
Comments
@Jupi007 can i take a look at this? I would like to get a little more details and what should be the behaviour that i should achieve. |
@shan-shaji ofc you can 🙂 |
ok thank you @Jupi007 |
@Jupi007 can i please get a bit more context about the feature? |
basically when you set the wallpaper from the chosen file you need to check what the current theme is and change the gsettings key corresponding to this |
@Feichtmeier , i am not that much familiar with gsettings. Really sorry.. do we have any docs? |
Sadly not many docs but you can check what WallpaperModel does and at some point it sets the wallpaper, I think I remember you only need to make a case for the dark wallpaper there |
Currently, the wallpaper is set twice: once for light theme once for the dark one. |
Got it |
@Jupi007v @Feichtmeier but i think the current behaviour supports different wallpaper depending on the theme. |
Nice 👍🙂 |
Closing, as this feature has been added in #321 |
In the current state, the wallpaper is defined for both dark/light theme.
GS supports to have different wallpaper depending on the theme, and it would be nice to add this feature here.
CC @YoussefLasheen if you want to grab it :)
The text was updated successfully, but these errors were encountered: