Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve setting row with slider #65

Closed
mivoligo opened this issue Sep 15, 2021 · 12 comments · Fixed by #74
Closed

Improve setting row with slider #65

mivoligo opened this issue Sep 15, 2021 · 12 comments · Fixed by #74
Labels
feature / enhancement Needs implementation
Projects

Comments

@mivoligo
Copy link
Collaborator

I think we need a way to reset the value set by a slider to the default value and show the current value.

Here's my idea. Let me know what you guys think.

Peek 2021-09-15 20-35

@Jupi007
Copy link
Collaborator

Jupi007 commented Sep 15, 2021

Good idea 👍
Maybe put the reset icon on the far right?

@Feichtmeier
Copy link
Member

There should be a way to show the value above the slider. This works for the discrete slider I think 🤔
Could you show how the reset button looks with primary color?

And nice idea!

@Feichtmeier Feichtmeier added the feature / enhancement Needs implementation label Sep 15, 2021
@mivoligo
Copy link
Collaborator Author

Maybe put the reset icon on the far right?

I've tried few different layouts and got some different issues with them. This one was the least problematic. I can show issues with other layouts.

@mivoligo
Copy link
Collaborator Author

mivoligo commented Sep 15, 2021

There should be a way to show the value above the slider. This works for the discrete slider I think thinking

IMO the discrete slider looks ugly 😉 and I think there's no easy way to display label above slider without making it discrete.

Could you show how the reset button looks with primary color?

Selection_001

@Jupi007
Copy link
Collaborator

Jupi007 commented Sep 15, 2021

And what about use soft grey?

@mivoligo
Copy link
Collaborator Author

Maybe there's more appropriate icon to symbolize reset. I used YaruIcons.refresh

@mivoligo
Copy link
Collaborator Author

mivoligo commented Sep 15, 2021

And what about use soft grey?

I used Yaru warmGrey here

Selection_003

@mivoligo
Copy link
Collaborator Author

The problem I have with the layout:
text | slider | reset

If the value is changed it looks fine:
Selection_008

But when there is a default value there's a lot of empty space on the right. IMO it doesn't look good:
Selection_006

We can have the slider to feel the empty space but then the slider size changes when the reset button shows up. And that makes changing value a bit weird.

@Feichtmeier
Copy link
Member

Another problem I see is that the default value only happens for gsetting stuff. I am not sure everything has actually a default value? Or does it? Maybe it is enough to just load the app with what gsetting gives you. If the slider is not connected to gsetting we could set our own default value 🤔
Needs a bit more thought I think

@mivoligo
Copy link
Collaborator Author

We can make that an optional property and only show when there's a default value. Anyway, I'll try to experiment a bit and maybe create something like the default value mark in GTK sliders.

@mivoligo
Copy link
Collaborator Author

OK, Here's how it can look with a mark showing the default value. I'm not sure about the color and size of the mark.
Screenshot:

Selection_001

In action:

Peek 2021-09-17 12-21

@Feichtmeier
Copy link
Member

This is a very nice solution. Looks great ant subtle 👍

@Feichtmeier Feichtmeier added this to To Do in Settings Sep 22, 2021
Settings automation moved this from To Do to Done Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature / enhancement Needs implementation
Projects
Development

Successfully merging a pull request may close this issue.

3 participants