Improved search

[Feichtmeier]

• move the search dialog atop of the left pane
• remove the close button

@jpnurmi @mivoligo since you both were not 100% happy with the search dialog - what about this instead?

[Jupi007]

This is way much better than the floating popup 👍

[mivoligo]

I like this way much more ❤️

[Feichtmeier]

light theme

[jpnurmi]

Getting better. 👍 Have you tried with a transparent barrier color to make it look less modal?

[jpnurmi]

Could it be an Autocomplete widget? Aren't those commonly used for searching? 🙂

[Feichtmeier]

Getting better. +1 Have you tried with a transparent barrier color to make it look less modal?

Well I wanted to avoid this design but I know you all want it so here it is :) This is what you guys all prefer, right?

I didn't try the autocomplete Widget yet

[mivoligo]

Again, we don't have a way to cancel the search using mouse without selecting an option. :)

[Feichtmeier]

Again, we don't have a way to cancel the search using mouse without selecting an option. :)

You can press ESC

[mivoligo]

I know but for that I would need to use my keyboard 😃

[Feichtmeier]

hehe ^^ well when you press the search button you need to use the keyboard because otherwise you can not type in the letters for search :)

[mivoligo]

hehe ^^ well when you press the search button you need to use the keyboard because otherwise you can not type in the letters for search :)

That's fair but what if I just clicked the search button out of curiosity. Maybe I was thinking it's a lens I can grab and move around 😉

[Feichtmeier]

@mivoligo for some reason the barrier dismiss does not work 🤷
must be something in that complex dialog hierarchy - since you guys like this design let's get it in and fix the barrier in another PR, ok?

[mivoligo]

ok 👍

[mivoligo]

It's true by default so we can omit this.

[mivoligo]

Maybe better to use Colors.transparent

[mivoligo]

It looks a bit weird in the narrow view:

[Feichtmeier]

Okay this sucks this need to be made better, with less code duplication and with the new navigtion I soon push, closing and re-opening the search issue =)