Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftPackageListUI AcknowledgmentsList() - shows no licenses #31

Closed
JulesMoorhouse opened this issue May 14, 2022 · 8 comments
Closed
Labels
help wanted Extra attention is needed

Comments

@JulesMoorhouse
Copy link

Hi,

Sorry to be so much trouble....

However, I have a package-list.plist with licenses in it..

But nothing showing in the UI.

image

I don't think I can see any logs on the Xcode debug..

Any ideas?

Jules.

@FelixHerrmann
Copy link
Owner

Haha, no problem!

Do you see any results when you use the packageList function?

@FelixHerrmann FelixHerrmann added the help wanted Extra attention is needed label May 14, 2022
@JulesMoorhouse
Copy link
Author

Ahhh.. forgot the add the plist to the project... just going off to hide under a rock... :|

Rather than setup yet another issue, is there anyway, I can change the style of the Licenses section header or remove it ?
I'm happy to put this in a new issue, if you'd rather...

@FelixHerrmann
Copy link
Owner

This happens to the best... 😂

Let me investigate the custom header thing, can you give me a bit more context why and how you want to change it?

@JulesMoorhouse
Copy link
Author

It just doesn’t fit with standard SwiftUI layout.

Looks like a style you’d see many iOS versions ago.

I’d be happy just not to have it at all.

@FelixHerrmann
Copy link
Owner

You can use the listStyle(_:) modifier on AcknowledgmentsList 🤔

@JulesMoorhouse
Copy link
Author

I have tried basically copying the contents AcknowledgmentsList but I think internal is stopping me using view models etc.

@JulesMoorhouse
Copy link
Author

Nice .listStyle(InsetGroupedListStyle()) fits well 👍

Thanks, think everything is working.

I do have a FontAwesome license I need to add, but I think I might have to create an empty package...

@FelixHerrmann
Copy link
Owner

FelixHerrmann commented May 14, 2022

👍

I do have a FontAwesome license I need to add, but I think I might have to create an empty package...

That actually would work, maybe I'll add support for custom licenses in the future but I don't want to make things too complex... nobody is forced to use the pre-build UI components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants