Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIES targets and target.index parameter needs to be exposed #145

Open
shahashka opened this issue Sep 19, 2022 · 2 comments
Open

GIES targets and target.index parameter needs to be exposed #145

shahashka opened this issue Sep 19, 2022 · 2 comments

Comments

@shahashka
Copy link

The cdt.causality.graph.GIES constructor is missing parameters to set the targets and target.index parameters for the score functions GaussL0penIntScore and GaussL0penObsScore. These parameters allow the user to specify the interventional targets and which data row has which intervention applied -- this is needed for the GIES algorithm. See https://search.r-project.org/CRAN/refmans/pcalg/html/GaussL0penIntScore-class.html

As is, the gies.R code uses source$getTargets() which by default sets targets to observational targets only. This means right now, the GIES algorithm in cdt does not handle interventional data properly.

@diviyank
Copy link
Collaborator

Hello !
Yes I forgot about this ! It's in the roadmap and I need to update this.

Thank you, noted.
Best,
Diviyan

@shahashka
Copy link
Author

Ok cool! Patiently will wait for this update :) (Do you have an approximate timeline?) Thanks for the reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants