Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation #31

Merged
merged 11 commits into from Sep 15, 2021
Merged

Fix navigation #31

merged 11 commits into from Sep 15, 2021

Conversation

FerMod
Copy link
Owner

@FerMod FerMod commented Sep 15, 2021

Fix navigation issues, clean up code and add missing documentation.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

When navigating after signing in, signing up or signing out, the last
screen would not properly pop from the navigation stack.

A better and cleaner solution should be implemented to reduce this type
of issues, and to have more control over each route access.

Issue #8
@FerMod FerMod added the cleanup Not a bug, not a feature, just code cleanup label Sep 15, 2021
@FerMod FerMod self-assigned this Sep 15, 2021
@FerMod FerMod marked this pull request as ready for review September 15, 2021 12:35
@FerMod FerMod merged commit 8c21fc1 into main Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Not a bug, not a feature, just code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant