Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement killSessions command #1552

Open
7 tasks
Tracked by #153
b1ron opened this issue Nov 23, 2022 · 0 comments
Open
7 tasks
Tracked by #153

Implement killSessions command #1552

b1ron opened this issue Nov 23, 2022 · 0 comments
Labels
code/feature Some user-visible feature is not implemented yet not ready Issues that are not ready to be worked on; PRs that should skip CI

Comments

@b1ron
Copy link
Contributor

b1ron commented Nov 23, 2022

What should be done?

Use cases to consider

Please note! For testing, authentication must be enforced (e.g. through --auth flag in MongoDB), so different users have different uids for sessions, and therefore testing is more accurate.

This is not the full list of use cases, but list of scenarios that comes to the mind:

  • Call killSessions for a non-existent session
  • Call killSessions for a session of another user (not the currently authenticated user)
  • Call killSessions for an existing session of the current user and try to call killSessions / refreshSessions / endSessions for the same session again.
  • Attempt to use lsid of the killed session for a new operation.
  • Call find, getMore, kill the current session, test what happens with the cursor (it will be closed)
  • Attempt to call killSessions for all possible states of a transaction
    • Move this item to transaction implementation task if irrelevant for now
  • Think of other test cases with "in progress" operations (if possible) - killing a session should kill such operations
    • Can this be implemented by attaching a context to each session, using this context for command execution, and closing this context if a session is killed?..
@b1ron b1ron added the code/feature Some user-visible feature is not implemented yet label Nov 23, 2022
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet not ready Issues that are not ready to be worked on; PRs that should skip CI
Projects
None yet
Development

No branches or pull requests

2 participants