Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove skipTigrisPushdown from tests #1913

Closed
Tracked by #4
AlekSi opened this issue Feb 2, 2023 · 0 comments · Fixed by #1957
Closed
Tracked by #4

Remove skipTigrisPushdown from tests #1913

AlekSi opened this issue Feb 2, 2023 · 0 comments · Fixed by #1957
Assignees
@noisersup
Labels
code/chore Code maintenance improvements
Milestone
v0.9.1

Comments

@AlekSi
Copy link
Member

AlekSi commented Feb 2, 2023 •
edited by rumyantseva

What should be done?

We should reach parity in pushdown implementation for pg and tigris handlers and remove skipTigrisPushdown from our tests.

Where?

Integration tests.

Replace that flag with "normal" skipping // TODO https://github.com/FerretDB/FerretDB/issues/1940

Definition of Done

  • skipTigrisPushdown is not present in the code anymore;
  • all handlers updated if needed;
  • integration/compatibility tests added/updated;
  • spot refactorings done.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Feb 2, 2023
@AlekSi AlekSi assigned ferretdb-bot and noisersup and unassigned ferretdb-bot Feb 2, 2023
@AlekSi AlekSi mentioned this issue Feb 9, 2023
Closed
@noisersup noisersup mentioned this issue Feb 13, 2023
Merged
9 tasks
@AlekSi AlekSi closed this as completed in c876337 Feb 13, 2023
@AlekSi AlekSi added this to the v0.9.1 milestone Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
None yet
Milestone
v0.9.1
Development

Successfully merging a pull request may close this issue.

Remove skipTigrisPushdown from tests noisersup/FerretDB
3 participants
@AlekSi @noisersup @ferretdb-bot