Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushdown all dot notation queries for Tigris #1914

Closed
4 tasks
AlekSi opened this issue Feb 2, 2023 · 1 comment
Closed
4 tasks

Pushdown all dot notation queries for Tigris #1914

AlekSi opened this issue Feb 2, 2023 · 1 comment
Labels
code/enhancement Some user-visible feature could work better not ready Issues that are not ready to be worked on; PRs that should skip CI

Comments

@AlekSi
Copy link
Member

AlekSi commented Feb 2, 2023

Blocked by tigrisdata-archive/tigris#838.


What should be done?

Let's implement dot notation pushdowns for everything we currently support for PostgreSQL.

  • Filtering document fields via foo.bar
  • Filtering array items via foo.0
  • Filtering fields of nested documents inside arrays via foo.0.bar
  • Filtering foo.0.bar.1.baz

Only arrays support should be missing, but let's check.

@AlekSi AlekSi added the code/enhancement Some user-visible feature could work better label Feb 2, 2023
@AlekSi AlekSi changed the title Pushdown dot notation queries for Tigris Pushdown dot notation queries for Tigris arrays Feb 2, 2023
@AlekSi
Copy link
Member Author

AlekSi commented Feb 10, 2023

If we manage to query nested documents inside arrays without specyfing index foo.bar for PostgreSQL, it's also in the scope of this issue (if it's possible to implement). {foo: {bar: 1}} or {foo: [{bar: 1}]} can be possible.

I don't think that {"foo": {"bar": 1}} and {"foo.bar": 1} are equivalents: the former matches the whole document, while the latter checks only one field. See https://www.mongodb.com/docs/manual/tutorial/query-embedded-documents/

@AlekSi AlekSi changed the title Pushdown dot notation queries for Tigris arrays Pushdown all dot notation queries for Tigris Feb 10, 2023
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 1, 2023
@AlekSi AlekSi closed this as not planned Won't fix, can't repro, duplicate, stale Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better not ready Issues that are not ready to be worked on; PRs that should skip CI
Projects
None yet
Development

No branches or pull requests

2 participants