Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor wire package to better support multi-section documents #274

Closed
AlekSi opened this issue Jan 17, 2022 · 1 comment
Closed

Refactor wire package to better support multi-section documents #274

AlekSi opened this issue Jan 17, 2022 · 1 comment
Assignees
@AlekSi
Labels
area/types Issues about data types, BSON, wire protocol, etc code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI
Milestone
v1.21.0

Comments

@AlekSi
Copy link
Member

AlekSi commented Jan 17, 2022

Replace a slice of Documents with lazy reading. Avoid reading all sections before passing them to the handler. That should help with large imports.

Keep (maybe deprecate) Document() method.

Add benchmarks.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jan 17, 2022
@AlekSi AlekSi self-assigned this Jan 17, 2022
@AlekSi AlekSi removed their assignment Feb 4, 2022
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 17, 2022
@AlekSi AlekSi added the area/types Issues about data types, BSON, wire protocol, etc label Jan 25, 2024
@AlekSi AlekSi self-assigned this Feb 22, 2024
@AlekSi AlekSi added this to the Next milestone Feb 22, 2024
@AlekSi
Copy link
Member Author

AlekSi commented Mar 5, 2024

Only benchmarks are left, but between #3700 and ycsb benchmarks in dance I think we are good.

@AlekSi AlekSi closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlekSi AlekSi

Labels
area/types Issues about data types, BSON, wire protocol, etc code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI
Projects
Current Engineering
Archived in project
Milestone
v1.21.0
Development

No branches or pull requests
1 participant
@AlekSi