Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topology construction is slow #617

Closed
3 tasks
termi-official opened this issue Mar 10, 2023 · 3 comments · Fixed by #753 or #974
Closed
3 tasks

Topology construction is slow #617

termi-official opened this issue Mar 10, 2023 · 3 comments · Fixed by #753 or #974
Assignees
@termi-official
Labels
good first issue Something to work on as a new contributor! performance

Comments

@termi-official
Copy link
Member

termi-official commented Mar 10, 2023 •
edited
Loading

Implementation of the topology construction is quite slow right now and can be optimized (type stability, allocations, ...).

Concrete ideas are

  1. Preallocate sparsity pattern
  2. Preallocate buffers with sufficient size to reduce allocations
  3. Separate mixed dimensional code path from non-mixed dimensional code path
@termi-official termi-official added performance good first issue Something to work on as a new contributor! labels Mar 10, 2023
@termi-official termi-official mentioned this issue Apr 21, 2023
Open
@termi-official termi-official added this to the v0.4.0 milestone Jun 7, 2023
@termi-official
Copy link
Member Author

termi-official commented Jun 7, 2023 •
edited
Loading

I added this to the next milestone, because fixing this is potentially breaking.

@termi-official termi-official self-assigned this Jun 29, 2023
@termi-official termi-official mentioned this issue Jun 29, 2023
Merged
@termi-official
Copy link
Member Author

Should I leave this open, because topology construction it is still not that fast?

@koehlerson
Copy link
Member

Let's keep it open, sorry was autoclosing due to merging

@koehlerson koehlerson reopened this Jul 6, 2023
@termi-official termi-official removed this from the v1.0.0 milestone Jul 7, 2023
@KnutAM KnutAM mentioned this issue May 20, 2024
Closed
@termi-official termi-official mentioned this issue Jul 1, 2024
Merged
5 tasks
@KnutAM KnutAM linked a pull request Jul 1, 2024 that will close this issue
ExclusiveTopology with ArrayOfVectorViews backend #974
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@termi-official termi-official

Labels
good first issue Something to work on as a new contributor! performance
Projects
None yet
Milestone
No milestone
2 participants
@termi-official @koehlerson