Fix ns_vs_diffeq fail #930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #930 +/- ##
=======================================
Coverage 93.86% 93.86%
=======================================
Files 36 36
Lines 5310 5310
=======================================
Hits 4984 4984
Misses 326 326 ☔ View full report in Codecov by Sentry. |
|
is this for #917 ? |
|
Too fast answer by @koehlerson :), wanted a pure CI run before filling the details |
|
The failure is basically #508 surfacing, but now with an error message :) Before it was just a silent failure. |
|
Then closing this as it sounds like it should be fixed soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened this to show the failure that happens when I just update the docs/Manifest.toml.
I'm not sure if this is related to existing work on this example, so this PR can be considered an issue. But would be great if there is an easy fix, since this prevents updating the docs/Manifest... Feel free to just work on this branch or make a separate!