Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ferrite.nfields should be called differently #444

Closed
kimauth opened this issue Apr 9, 2022 · 1 comment · Fixed by #653
Closed

Ferrite.nfields should be called differently #444

kimauth opened this issue Apr 9, 2022 · 1 comment · Fixed by #653

Comments

@kimauth
Copy link
Member

kimauth commented Apr 9, 2022 

grid = generate_grid(Quadrilateral, (1,1))
dh = DofHandler(grid)
push!(dh, :u, 2)
close!(dh)
julia> nfields(dh)
9

julia> Ferrite.nfields(dh)
1

The first one calls Julias nfields.
@kimauth kimauth mentioned this issue Apr 10, 2022
Closed
@termi-official
Copy link
Member

Addressed in #486 because it has been an issue several times.

termi-official pushed a commit that referenced this issue Mar 29, 2023
Rename nfields to num_fields (#444).
2c24786
@termi-official termi-official mentioned this issue Mar 29, 2023
Merged
fredrikekre pushed a commit that referenced this issue Apr 1, 2023
@fredrikekre
Remove Ferrite.nfields
b7a79b7 
This patch deprecates the internal function `nfields(dh)` in favor of
`length(getfieldnames(dh))`. The reason is twofold: `nfields` where
barely used, not even internally, and `nfields` was easy to confuse with
the existing `Base.nfields` function that would still work, but behave
quite differently.

Closes #444.
fredrikekre pushed a commit that referenced this issue Apr 1, 2023
@termi-official
Remove Ferrite.nfields (#653)
358e148 
This patch deprecates the internal function `nfields(dh)` in favor of
`length(getfieldnames(dh))`. The reason is twofold: `nfields` where
barely used, not even internally, and `nfields` was easy to confuse with
the existing `Base.nfields` function that would still work, but behave
quite differently.

Closes #444.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove and deprecate nfields Ferrite-FEM/Ferrite.jl
2 participants
@termi-official @kimauth