New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Etsy FeatureAPI and Rollout Unite #32
Conversation
This is awesome and very timely. We've been looking at using Rollout, but realized it lacked the A/B testing functionality that Feature API has. Did you do a write-up about usage anywhere? Or maybe you'd be kind enough to add some docs to your pull? :) |
Here are the docs: Basic Feature Gate Using Variants Creating a Feature Configuration get a rollout object in Rails console get list of features turn off "background" turn on "background" turn on "background" for 10% users turn on "background" for some users: admin, groups, etc session bucketing (default) user bucketing random bucketing set variants red, green and blue all at 33% override variant via URL If you have multiple features to test, use commas to separate the features. For example, if you had features "background", "color", and "size" the url would look like this: |
Very helpful, thank you. |
Is there a status on this? It's very interesting work! |
Will this be merged? |
This looks cool. Please be patient with me, as I just took over this project and have a lot to catch up on! :-) I'll get to this soon. |
Awesome, looking forward to seeing this get merged! David
|
This is a fantastic set of features. I'd love to perhaps see this in a Rollout version 3, but there are a couple of key concerns I have with version 2 that I'd like to address first. |
…ing if data is sane. Boolean values (@admin, @internal) were not checked properly. Made to_boolean method.
Any updates on this PR? Plans to merge it and release a new Rollout version? |
+1 |
Hi, I no longer have contributor access to this github repository since I left FetLife, and I have not heard back from FetLife regarding what they plan to do with Rollout. I even volunteered to remain a contributor. Sorry about this. There's not much I can do until they respond. |
Adding rails-specific stuff to this codebase is going to greatly limit the number of people who can use this. I use this in non-rails projects (as well as projects with wildly different rails versions including 2.3). I could see creating a separate project to do those opinionated rails-specific things that leverages rollout, but I would not be in favor of tying rollout to a specific rails version. |
For what my opinion is worth, I whole heartedly agree with @eric. I would advise that this be an extension of rollout and live in its own project and gem. Compatibility and separation of concerns (that is, keeping the project small and simple) are valid points. |
I agree. -----Original Message----- For what my opinion is worth, I whole heartedly agree with @eric. I would advise that this be an extension of rollout and live in its own project and gem. |
I agree too... so let's close this issue. But we are happy to add reference to this extension of rollout if it was moved to the separate project. |
I worked at etsy for several years. Now that I'm back in a rails shop (CarWoo!) I started looking for an alternative to our "ServerConfig", which just got open sourced as "Feature API" https://github.com/etsy/feature
I have been in the process of porting / merging etsy's featureAPI into rollout. I like your redis based configuration it make a ton of sense. So I just added support for url overrides, variants and a few other useful items. I also added tighter integration into Rails, with helpers and rollout_context for accessing user objects, etc. Still a bit clunky, but we are rolling it into prod this week.
Let me know what you think, maybe a 3.0 version of rollout??