Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popper position update does not position itself entirely in viewport #401

Closed
atomiks opened this issue Aug 23, 2017 · 1 comment · Fixed by #402
Closed

Popper position update does not position itself entirely in viewport #401

atomiks opened this issue Aug 23, 2017 · 1 comment · Fixed by #402
Assignees
@FezVrasta
Labels
bug Something is not working. PRIORITY: medium TARGETS: core Utility functions, lifecycle, core library stuff.

Comments

@atomiks
Copy link
Collaborator

atomiks commented Aug 23, 2017

CodePen demo

https://codepen.io/anon/pen/YxvXRe

Steps to reproduce the problem

  1. Resize the browser window to make it smaller (with sufficient speed)

What is the expected behavior?

The popper's position should update to the correct position (entirely inside the viewport) instantly

What went wrong?

It 'lags' and part of the popper is left outside the viewport as the window is resized

Any other comments?

This seems to be a regression which was fixed by this issue: #251
@FezVrasta
Copy link
Member

Yes it #251 again... Fixing #302 reintroduced this one, damn it.

@FezVrasta FezVrasta added bug Something is not working. DIFFICULTY: medium PRIORITY: medium TARGETS: core Utility functions, lifecycle, core library stuff. labels Aug 23, 2017
@FezVrasta FezVrasta self-assigned this Aug 24, 2017
FezVrasta pushed a commit that referenced this issue Aug 24, 2017
fix(popper): Fixed regression #401
4ee94b1
@FezVrasta FezVrasta mentioned this issue Aug 24, 2017
Merged
FezVrasta added a commit that referenced this issue Aug 28, 2017
@FezVrasta
fix(popper): Fixed regression #401 (#402)
1b3a82d
FezVrasta pushed a commit that referenced this issue Aug 29, 2017
Revert "fix(popper): Fixed regression #401 (#402)"
19b4f7f 
This reverts commit 1b3a82d.
FezVrasta added a commit that referenced this issue Aug 29, 2017
@FezVrasta
Revert "fix(popper): Fixed regression #401 (#402)" (#408)
37056c1 
This reverts commit 1b3a82d.
@atomiks atomiks mentioned this issue Oct 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FezVrasta FezVrasta

Labels
bug Something is not working. PRIORITY: medium TARGETS: core Utility functions, lifecycle, core library stuff.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(popper): Fixed regression #401 floating-ui/floating-ui
2 participants
@FezVrasta @atomiks