Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing comma in evitaQL #493

Open
novoj opened this issue Mar 15, 2024 · 1 comment
Open

Trailing comma in evitaQL #493

novoj opened this issue Mar 15, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@novoj
Copy link
Collaborator

novoj commented Mar 15, 2024

When parts of the query are commented out or lines are moved, there is usually a parsing error due to the trailing comma. If our parser automatically ignores the last comma if there is no additional child constraint, we could make life easier for developers.

What is your opinion on this @lukashornych ?

@novoj novoj added the enhancement New feature or request label Mar 15, 2024
@novoj novoj added this to the Alpha milestone Mar 15, 2024
@lukashornych
Copy link
Collaborator

The only thing I have against it, is that developers leave these trailing commas and it makes a mess, but that's not really a reason not to do it. I agree that it could be useful. I'll check what it would mean to implement it.

@novoj novoj modified the milestones: Alpha, Beta Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants