Feature/framework and nuget package stuff #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e nuget package rather than project references.
…ory. added logic to add dll path.
Fixing formatting of file
Fixing formatting issues.
Correcting TargetFramework
Correcting Framework issues
Fixing formatting
Correcting to include the conditional for framework
Adding conditional logic for framework
Adding conditional logic for framework
Adding framework conditional
Adding conditional logic for framework
Benchmark Comparison - .NET Framework 4.8Benchmarking comparison between this Pull Request and the comitted values at benchmarks/results dcraw summary:
better: 1, geomean: 1.132
total diff: 1
No Slower results for the provided threshold = 10% and noise filter = 0.3ns.
| Faster | base/diff | Base Median (ns) | Diff Median (ns) | Modality|
| --------------------------------------------------------------- | ---------:| ----------------:| ----------------:| --------:|
| FileOnQ.Imaging.Raw.Benchmarking.DcrawProcess.ProcessIntoBitmap | 1.13 | 12679593700.00 | 11205866100.00 | |
No file given
dcraw-whitebalance summary:
worse: 3, geomean: 1.175
total diff: 3
| Slower | diff/base | Base Median (ns) | Diff Median (ns) | Modality|
| ---------------------------------------------------------------------------- | ---------:| ----------------:| ----------------:| --------:|
| FileOnQ.Imaging.Raw.Benchmarking.DcrawProcessWhiteBalance.ProcessIntoBitmap | 1.20 | 10867874500.00 | 13067031400.00 | |
| FileOnQ.Imaging.Raw.Benchmarking.DcrawProcessWhiteBalance.ProccessAndWrite | 1.18 | 10912099500.00 | 12869572300.00 | |
| FileOnQ.Imaging.Raw.Benchmarking.DcrawProcessWhiteBalance.ProccessIntoMemory | 1.14 | 10864863600.00 | 12434089100.00 | |
No Faster results for the provided threshold = 10% and noise filter = 0.3ns.
No file given
thumbnail No differences found between the benchmark results with threshold 10%.
Benchmark Results - .NET Framework 4.8dcraw
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5), VM=Hyper-V
Intel Xeon Platinum 8272CL CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores
[Host] : .NET Framework 4.8 (4.8.4420.0), X64 RyuJIT
Job-GHSIOX : .NET Framework 4.8 (4.8.4420.0), X64 RyuJIT
Runtime=.NET Framework 4.8 InvocationCount=1 LaunchCount=1
UnrollFactor=1
dcraw white balance
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5), VM=Hyper-V
Intel Xeon CPU E5-2673 v3 2.40GHz, 1 CPU, 2 logical and 2 physical cores
[Host] : .NET Framework 4.8 (4.8.4420.0), X64 RyuJIT
Job-GHSIOX : .NET Framework 4.8 (4.8.4420.0), X64 RyuJIT
Runtime=.NET Framework 4.8 InvocationCount=1 LaunchCount=1
UnrollFactor=1
thumbnail
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5), VM=Hyper-V
Intel Xeon Platinum 8370C CPU 2.80GHz, 1 CPU, 2 logical and 2 physical cores
[Host] : .NET Framework 4.8 (4.8.4420.0), X64 RyuJIT
Job-GHSIOX : .NET Framework 4.8 (4.8.4420.0), X64 RyuJIT
Runtime=.NET Framework 4.8 InvocationCount=1 LaunchCount=1
UnrollFactor=1
Benchmark Comparison - .NET 5Benchmarking comparison between this Pull Request and the comitted values at benchmarks/results dcraw summary:
better: 3, geomean: 1.245
total diff: 3
No Slower results for the provided threshold = 10% and noise filter = 0.3ns.
| Faster | base/diff | Base Median (ns) | Diff Median (ns) | Modality|
| ---------------------------------------------------------------- | ---------:| ----------------:| ----------------:| --------:|
| FileOnQ.Imaging.Raw.Benchmarking.DcrawProcess.ProccessIntoMemory | 1.25 | 13485240850.00 | 10816475550.00 | |
| FileOnQ.Imaging.Raw.Benchmarking.DcrawProcess.ProcessIntoBitmap | 1.25 | 13912648400.00 | 11170116600.00 | |
| FileOnQ.Imaging.Raw.Benchmarking.DcrawProcess.ProccessAndWrite | 1.24 | 13826707400.00 | 11116406400.00 | |
No file given
dcraw-whitebalance No differences found between the benchmark results with threshold 10%.
thumbnail No differences found between the benchmark results with threshold 10%.
Benchmark Results - .NET 5dcraw
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5)
Intel Xeon Platinum 8272CL CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores
.NET SDK=6.0.101
[Host] : .NET 5.0.8 (5.0.821.31504), X64 RyuJIT
Job-AXZZSH : .NET 5.0.8 (5.0.821.31504), X64 RyuJIT
Runtime=.NET 5.0 InvocationCount=1 LaunchCount=1
UnrollFactor=1
dcraw white balance
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5)
Intel Xeon CPU E5-2673 v4 2.30GHz, 1 CPU, 2 logical and 2 physical cores
.NET SDK=6.0.101
[Host] : .NET 5.0.8 (5.0.821.31504), X64 RyuJIT
Job-TGELAS : .NET 5.0.8 (5.0.821.31504), X64 RyuJIT
Runtime=.NET 5.0 InvocationCount=1 LaunchCount=1
UnrollFactor=1
thumbnail
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5)
Intel Xeon CPU E5-2673 v4 2.30GHz, 1 CPU, 2 logical and 2 physical cores
.NET SDK=6.0.101
[Host] : .NET 5.0.8 (5.0.821.31504), X64 RyuJIT
Job-BJNJDA : .NET 5.0.8 (5.0.821.31504), X64 RyuJIT
Runtime=.NET 5.0 InvocationCount=1 LaunchCount=1
UnrollFactor=1
Benchmark Comparison - .NET 6Benchmarking comparison between this Pull Request and the comitted values at benchmarks/results dcraw No differences found between the benchmark results with threshold 10%.
dcraw-whitebalance summary:
worse: 3, geomean: 1.161
total diff: 3
| Slower | diff/base | Base Median (ns) | Diff Median (ns) | Modality|
| ---------------------------------------------------------------------------- | ---------:| ----------------:| ----------------:| --------:|
| FileOnQ.Imaging.Raw.Benchmarking.DcrawProcessWhiteBalance.ProcessIntoBitmap | 1.17 | 11125554700.00 | 13056178600.00 | |
| FileOnQ.Imaging.Raw.Benchmarking.DcrawProcessWhiteBalance.ProccessIntoMemory | 1.16 | 10869754950.00 | 12556246800.00 | |
| FileOnQ.Imaging.Raw.Benchmarking.DcrawProcessWhiteBalance.ProccessAndWrite | 1.15 | 11119931100.00 | 12821683900.00 | |
No Faster results for the provided threshold = 10% and noise filter = 0.3ns.
No file given
thumbnail summary:
worse: 3, geomean: 1.240
total diff: 3
| Slower | diff/base | Base Median (ns) | Diff Median (ns) | Modality|
| -------------------------------------------------------------- | ---------:| ----------------:| ----------------:| -------- |
| FileOnQ.Imaging.Raw.Benchmarking.Thumbnail.ThumbnailAndWrite | 1.30 | 10572100.00 | 13791650.00 | |
| FileOnQ.Imaging.Raw.Benchmarking.Thumbnail.ThumbnailIntoMemory | 1.24 | 9148450.00 | 11354500.00 | bimodal |
| FileOnQ.Imaging.Raw.Benchmarking.Thumbnail.ThumbnailIntoBitmap | 1.18 | 279418400.00 | 329343300.00 | |
No Faster results for the provided threshold = 10% and noise filter = 0.3ns.
No file given
Benchmark Results - .NET 6dcraw
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5)
Intel Xeon CPU E5-2673 v3 2.40GHz, 1 CPU, 2 logical and 2 physical cores
.NET SDK=6.0.101
[Host] : .NET 6.0.1 (6.0.121.56705), X64 RyuJIT
Job-KRKVVZ : .NET 6.0.1 (6.0.121.56705), X64 RyuJIT
Runtime=.NET 6.0 InvocationCount=1 LaunchCount=1
UnrollFactor=1
dcraw white balance
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5)
Intel Xeon CPU E5-2673 v3 2.40GHz, 1 CPU, 2 logical and 2 physical cores
.NET SDK=6.0.101
[Host] : .NET 6.0.1 (6.0.121.56705), X64 RyuJIT
Job-BSGGGE : .NET 6.0.1 (6.0.121.56705), X64 RyuJIT
Runtime=.NET 6.0 InvocationCount=1 LaunchCount=1
UnrollFactor=1
thumbnail
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5)
Intel Xeon CPU E5-2673 v4 2.30GHz, 1 CPU, 2 logical and 2 physical cores
.NET SDK=6.0.101
[Host] : .NET 6.0.1 (6.0.121.56705), X64 RyuJIT
Job-UJGXTF : .NET 6.0.1 (6.0.121.56705), X64 RyuJIT
Runtime=.NET 6.0 InvocationCount=1 LaunchCount=1
UnrollFactor=1
|
SkyeHoefling
suggested changes
Feb 3, 2022
There was a problem hiding this comment.
@kenny-sellers thanks for the contribution! There are conflicts with the latest changes in main can you resolve those and let me know. I'll do a formal review then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #36
Fixes: #30
Fixes: #29
Fixes: #26
Description
Changing the consuming applications to use an local NuGet package at build time rather than project references or an actual NuGet packages. Adjusting all projects to be multi-targeted (.NET 4.8, .NET 5.0, and .NET 6.0). Adjusting build process to place native binaries in a runtime directory. Added code to load the images correctly.
Improved the build process to be one build for PRs and Main builds. Added benchmarking for all targeted frameworks.
Merge Checklist