Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverted radial progress drawing #8

Merged

Conversation

rzimmer
Copy link
Contributor

@rzimmer rzimmer commented Oct 21, 2014

Thank you for the great library! We had the requirement to invert the way the progress is drawing in radial mode, so here is a corresponding pull request of a working version. Hopefully you can include this upstream. Feel free to comment on this request.

More pull requests may follow...

@rzimmer
Copy link
Contributor Author

rzimmer commented Oct 21, 2014

As it was so easy, I just added a counterclockwise drawing mode which works for both the normal and the inverted mode.

mInverted = inverted;
}

/**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the counterClockwise getter/setter.

@rzimmer
Copy link
Contributor Author

rzimmer commented Oct 22, 2014

Sorry, I forgot about this, you are right. I just added another commit with the mentioned changes.

@rzimmer rzimmer force-pushed the feature/inverted_progress_drawing branch from 78177ad to 0e9c966 Compare October 22, 2014 07:58
FilipPudak added a commit that referenced this pull request Oct 23, 2014
@FilipPudak FilipPudak merged commit dc48bf0 into FilipPudak:master Oct 23, 2014
@rzimmer rzimmer deleted the feature/inverted_progress_drawing branch January 21, 2015 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants