Bugfix: Correctly honor showStroke property #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pace for a not to be drawn stroke)
FilipPudak
added a commit
that referenced
this pull request
Oct 21, 2014
Bugfix: Correctly honor showStroke property Nice find! Merge gladly accepted 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, space for a stroke is reserved even if no stroke is to be drawn. You have to manually set strokeWidth to 0 to prevent this. This pull requests is taking into account the showStroke property correctly. It will only reserve space for the stroke if a stroke is requested to be drawn.