Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent handling of line editor number in base 0 vs base 1 #84

Open
FilipVanVooren opened this issue May 1, 2023 · 0 comments
Open
Labels
bug Something isn't working editor refactor

Comments

@FilipVanVooren
Copy link
Owner

Some routines in Stevie use base 0 for addressing the line of interest. While others use base 1 to address the same.
This inconsistency leads to subtle and very hard to find bugs.

Refactoring is necessary with the target of reaching the following:

  • All internal line addressing shall use base 0
  • Only when displaying or doing input of a line number on screen, base 1 shall be used
  • In all appropriate code places, conversion from base 1 to base 0 is required.
@FilipVanVooren FilipVanVooren added bug Something isn't working editor refactor labels May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor refactor
Projects
None yet
Development

No branches or pull requests

1 participant