Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to always translate doesn't show on some sites #11

Closed
DuckOfDuckness opened this issue Aug 8, 2020 · 6 comments
Closed

Option to always translate doesn't show on some sites #11

DuckOfDuckness opened this issue Aug 8, 2020 · 6 comments

Comments

@DuckOfDuckness
Copy link

Example of one such website: http://cafe.daum.net/Dreamcatcher7
image

Originally posted by @DuckOfDuckness in #6 (comment)

@FilipePS
Copy link
Owner

FilipePS commented Aug 8, 2020

All the content on this site is in an "iframe". I don't know why they did it.
Language detection is based only on the main page document. It is possible to detect the language of iframes but I don't intend to do that.
Iframes should be used for content outside the site, not as main content.

@DuckOfDuckness
Copy link
Author

Well that's super annoying, but definitely not your fault.
Would it be possible to add an advanced option to manually tell the extension what language a site is in as a workaround?

@FilipePS
Copy link
Owner

FilipePS commented Aug 9, 2020

Instead of specifying the language of the page, do you think it's best to do this #13?

@DuckOfDuckness
Copy link
Author

If that can work on this site even with its weird iframe set-up, I guess that might be a more elegant solution. Manually clicking the translate button does translate from the correct language.

@FilipePS
Copy link
Owner

Is your goal just to show the correct language, or do you want the page to be translated automatically?

@DuckOfDuckness
Copy link
Author

I would like the page to be translated automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants