Skip to content
This repository has been archived by the owner on Jul 27, 2020. It is now read-only.

Switch to using superagent so that it's isomorphic #16

Closed
wheresrhys opened this issue Jul 29, 2014 · 2 comments
Closed

Switch to using superagent so that it's isomorphic #16

wheresrhys opened this issue Jul 29, 2014 · 2 comments

Comments

@wheresrhys
Copy link
Contributor

As search is POST based it won't work without CORS, but the GET requests could potentially work on the client side. Would be nice to integrate promises (e.g. https://github.com/wheresrhys/superagent-promises) into it too. Perhaps promisification could be configurable

@richard-still-ft
Copy link
Contributor

I'm not sure this is a genuine requirement. API keys are private and should never be in the browser. There is currently no use case where we would call a core API directly from the browser. @commuterjoy you also raised this as an issue, what are your thoughts?

@commuterjoy
Copy link
Member

Yeah, I'd put it low down on a list of priorities until we understand what sort of site we are building. The more client-side rendered code we use the more an isomorphic client library make sense (albeit via a proxy to mask api keys).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants