Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move template files from templates directory into components #198

Closed
benbarnett opened this issue Jul 18, 2018 · 4 comments
Closed

Move template files from templates directory into components #198

benbarnett opened this issue Jul 18, 2018 · 4 comments
Assignees

Comments

@benbarnett
Copy link
Contributor

So that the templates are stored directly against the components that use them.

@benbarnett benbarnett added this to the Organise by component milestone Jul 18, 2018
@chee
Copy link
Member

chee commented Aug 15, 2018

these need moved to components (leaving this path as a pass-thru), then updated in the apps that use them, and then deleted:

  • myft/templates/save-for-later.html
  • myft/templates/unsave-for-later.html

these are already in components, (this path is a pass-thru). still need updated in the apps that use them, and then deleted:

  • myft/templates/follow.html

@chee
Copy link
Member

chee commented Aug 15, 2018

Also can we do the same thing with save/unsave that we did to follow/unfollow (make them the same component with an option?)

@chee
Copy link
Member

chee commented Aug 15, 2018

i'm going to do a PR updating the uses from within n-myft-ui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants