This repository has been archived by the owner on Nov 26, 2021. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
previously approved these changes
Feb 14, 2019
…, now we have a boilerplate class!
JakeChampion
reviewed
Mar 4, 2019
JakeChampion
reviewed
Mar 4, 2019
JakeChampion
reviewed
Mar 4, 2019
JakeChampion
reviewed
Mar 4, 2019
Co-Authored-By: gvonkoss <gabivk@gmail.com>
… and use the new interface for Build class
…ecute` to use a local circleci on developers machines
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin building
init
commandTemplates need more attention— currently I've mostly copy pasted them over from obt boilerplate in order to have files to amend. The moar feedback the better, on the templates.
They don't fall into line with all of the functionality splitting that we've discussed, but we can always add/remove/edit. e.g. we don't know exactly how we'll be buildling the demos, so the current demo templates are placeholders.
none of this code is linted, so I do have to go back and do that should you find extra spaces/missing
;
etc.The prompts are recursive, so you can change any individual part of the answers at the end. I don't know if this is overkill, if there are too many prompts, etc.