You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OBT has a bug where it builds demos indentically when building multiple of them that share the same template. Build service shouldn't have this issue as it only compiles one demo at a time, but with o-header, it generates the core demo for the enhanced one.
The text was updated successfully, but these errors were encountered:
Tried to reproduce this locally with o-header in integration tests and couldn't:
it('should not cache demo templates for the same component when built concurrently',function(){consttestModule='o-header';constrequest1=newPromise((resolve,reject)=>{request(this.app).get(`/v2/demos/${testModule}/main`).set('Connection','close').end(function(err,res){if(err)returnreject(err);resolve(res.text);});});constrequest2=newPromise((resolve,reject)=>{request(this.app).get(`/v2/demos/${testModule}/mega-menu`).set('Connection','close').end(function(err,res){if(err)returnreject(err);resolve(res.text);});});returnPromise.all([request1,request2]).then(([response1,response2])=>{assert.notDeepEqual(response1,response2);});});it('should not cache demo templates for the same component when built in serial',function(){consttestModule='o-header';constrequest1=newPromise((resolve,reject)=>{request(this.app).get(`/v2/demos/${testModule}/main`).set('Connection','close').end(function(err,res){if(err)returnreject(err);resolve(res.text);});});constrequest2=newPromise((resolve,reject)=>{request(this.app).get(`/v2/demos/${testModule}/mega-menu`).set('Connection','close').end(function(err,res){if(err)returnreject(err);resolve(res.text);});});returnrequest1.then((response1)=>{returnrequest2.then((response2)=>{assert.notDeepEqual(response1,response2);});});});
[originally reported by @AlbertoElias]
OBT has a bug where it builds demos indentically when building multiple of them that share the same template. Build service shouldn't have this issue as it only compiles one demo at a time, but with o-header, it generates the core demo for the enhanced one.
The text was updated successfully, but these errors were encountered: