Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Handle Sass parse errors #20

Closed
notlee opened this issue Aug 12, 2019 · 2 comments
Closed

Handle Sass parse errors #20

notlee opened this issue Aug 12, 2019 · 2 comments

Comments

@notlee
Copy link
Contributor

notlee commented Aug 12, 2019

Relates to: https://sentry.io/organizations/nextftcom/issues/1135337606/?environment=prod&project=1296601

Sassdoc generation for o-normalise@1.3.0 fails as it has a missing semicolon at the end of a file. This is apparently valid Sass and appears to be an issue with scss-comment-parser which sassdoc depends on.

It's not a big issue as the missing semicolon has been added in a patch release of o-normalise, but some users continue to try to access the Sassdoc for the previous version.

I don't think we can catch and handle similar rare cases as the error is thrown within a sassdoc stream we don't have access to (unless we use node's deprecated domain maybe?) I've opened an issue against sassdoc with proposed solution.

@notlee
Copy link
Contributor Author

notlee commented Sep 20, 2019

The PR was released in sassdoc@2.7.1 🎉 configured Renovate and going to let that open the PR for us

@notlee
Copy link
Contributor Author

notlee commented Sep 20, 2019

#28

@notlee notlee closed this as completed Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant